StarCitizenTools / mediawiki-skins-Citizen

A beautiful, usable, responsive MediaWiki skin with in-depth extension support. Originally developed for the Star Citizen Wiki.
https://www.mediawiki.org/wiki/Skin:Citizen
GNU General Public License v3.0
206 stars 52 forks source link

html.skin-citizen-dark doesn't work for Auto mode #877

Open RothwellWiki opened 2 weeks ago

RothwellWiki commented 2 weeks ago

Describe the Bug

Objects I target with html.skin-citizen-dark don't change to their dark theme when on auto mode. Is this a bug or do I have to do add something like html.skin-citizen-auto to them too?

Auto Dark

Steps to reproduce the behavior:

  1. Go to 'https://www.rothwell-leeds.co.uk/wiki/Main_Page' in your browser/device's dark mode
  2. Toggle from auto to dark
  3. See difference

Expected Behavior

Objects with html.skin-citizen-dark should change when in auto.

System

alistair3149 commented 2 weeks ago

Yes it is the intended behavior. We refactored how theme classes are handled to align with the current standards in MediaWiki. The skin-citizen-dark and the similar classes are getting deprecated and being replaced with the new skin-theme-clientpref- classes. You can see how they are being used on this page: https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis