StarCitizenWiki / mediawiki-extensions-EmbedVideo

GDPR focused EmbedVideo. Supports YouTube, Twitch, Spotify and SoundCloud
https://www.mediawiki.org/wiki/Extension:EmbedVideo_(fork)
Other
27 stars 15 forks source link

undefined array key "width" when using a local file #64

Closed edg-l closed 1 year ago

edg-l commented 1 year ago

Describe the bug When using a local video file (mp4) it looks like the extension fails to get the size and it ends up shown full size, instead of the specified one, it also reports the following warning:

Warning: Undefined array key "width" in /var/www/html/extensions/EmbedVideo/includes/Media/VideoHandler.php on line 98

Warning: Undefined array key "height" in /var/www/html/extensions/EmbedVideo/includes/Media/VideoHandler.php on line 98

Using it like this: [[File:Jump-height.mp4|right|300px|gif|muted]]

Edit: this was tested on develop, and also happens on 3.2.8

Technical information:

Additional context Add any other context about the problem here.

octfx commented 1 year ago

Should be adressed in develop branch

Using it like this: [[File:Jump-height.mp4|right|300px|gif|muted]]

Tested this and did not get any warnings / Saw the correct height