search

StarGate01 / AmongUs-Mumble

Mumble VoIP Plugin and mod for the popular game "Among Us" to enable Proximity Voice Chat.
GNU General Public License v3.0
109 stars 13 forks source link

Set a player's mumble context if they're in a live game. #21

Closed alisenai closed 3 years ago

alisenai commented 3 years ago

When joining a lobby, it may cause problems as you won't be able to talk to your friends who aren't also in that lobby. Leaving a game often also does not trigger a "Game joined or ended" and this can also cause similar issues.

As per the wiki, the context should not be updated every frame -- will have to fix the issue with detecting game state changes.

StarGate01 commented 3 years ago

As per the current implementation, the Mumble context is initialized once the game starts, so all playersshould have the same context anyway. If I understand correctly the problem is that someone has the game not running at all, and wants to talk to the channel?

This requires a solution like the POSIX fake client, where Mumble is notified about the player but no game is running. Alternativly, we could evaluate the usage of the manual placement plugin to just set the context. However, I never got the plugins to work with each other, but maybe the encoding of the context TEAM was not correct.

Leaving a game often also does not trigger a "Game joined or ended" and this can also cause similar issues.

Lets deal with that in #22 .

LelouBil commented 3 years ago

If someone doesn't have the same context or any context set, they will just hear/be heard non positionally.

StarGate01 commented 3 years ago

Should be fixed by #27 . If not, feel free to reopen.