search

StarGazer1258 / BeatDrop

The ultimate content-manager for Beat Saber. Download mods, songs, and more!
Other
326 stars 92 forks source link

Songs in Library are not detected #6

Closed JtheDroid closed 5 years ago

JtheDroid commented 5 years ago

Environment: Device - PC OS - Windows 10 Home, Version 1809, Build 17763.437 BeatDrop Version - 2.1.6

Description of bug: On a fresh install or after scanning for songs, downloaded songs are not detected properly: When selecting a song listed under 'BeatSaver' (as described below), it is not marked as 'In Library' and the Download button appears. When clicking 'Download Missing Songs' for a playlist, all songs are downloaded. After a song has been downloaded again through BeatDrop, it is marked correctly until scanning for songs again. The songs still do show up under Library -> Songs

Steps to reproduce: Steps to reproduce the behavior:

  1. Go to settings, Click on 'Scan for Songs'
  2. Open a song listed under 'BeatSaver' (not 'Library') a.1 Go to one of the 'BEATSAVER' categories (e.g. 'Top Downloaded') a.2 Select a song or a.1 Search for a song b.2 Click the result under 'BeatSaver'
  3. Song is not detected as 'In Library'

Expected behavior: Downloaded songs are detected (marked as 'In Library') and not downloaded unnecessarily

Actual Behavior When selected via BeatSaver, songs are not detected as downloaded and will be downloaded again. Once downloaded through BeatDrop, songs are marked as 'In Library' until restarting BeatDrop or scanning songs When selected via Library, songs are correctly detected

Screenshots: Example: Believer (31-11) Song folder: image Search results: (still appears in library) image

'Library' search result: image 'BeatSaver' search result: image After re-downloading: image

In 'Top Downloaded' list: Initially/After scanning for songs: image After downloading it again: image

brandonhenry commented 5 years ago

Observations:

Solution:

There are many, but I think I'm going to go with adding an equals method to compare songs via name, subname, authorname, and BPM

brandonhenry commented 5 years ago

Hashes weren't actually being generated. updated!

StarGazer1258 commented 5 years ago

Seems as this has been fixed by #36.