StarLabsLtd / firmware

68 stars 4 forks source link

[Starbook MK VI - AMD] Fan curve adjustment 24.03 is way more noisier than before #156

Closed lil0r closed 2 months ago

lil0r commented 3 months ago

Flashed Bios 24.03 (EC 24.03) before easter and I noticed a significant change in noise through fan behaviour. Single simple workloads like browsing web with chrome or firefox cause to spin the fan up. Running a windows VM sounds like a jet taking off. Beforehand I was on Bios 1.16.0 (EC 2.6) which was almost always silent until I compiled a kernel or something.

Is there any way to change powermanagement to something more like EC 2.6?

Sean-StarLabs commented 3 months ago

Not from the firmware (although changing the fan curve will indirectly change it).

lil0r commented 3 months ago

Thanks Sean, what can I do to tame the jet engine?

Sean-StarLabs commented 3 months ago

Change the fan curve, or performance settings in the os

lil0r commented 3 months ago

Thanks Sean,

Havent changed anything other than the bios/EC update - could you please elaborate what has changed in regard to PM & fan management in the two verions? Otherwise, it will be trial and error...

Sean-StarLabs commented 3 months ago

Nothing specific (granted, AMD change logs leave a lot to be desired) but something's getting lost in translation. Fan curve has 3 settings as does the performance, sure, trail and error, but turn one down, if it's not quiet enough, turn the other down

lil0r commented 3 months ago

Fan curve in the Bios 1.16.0 (EC 2.6) previously were a bit odd - Normal profil was much quiter than quite profil. First thing I played around obviously was the Bios setting, without much effect. Since that lead to nowhere, I started manually tweaking the ryzen PM Table. But really, I dont want to reverse engineer the changes - hence I asked.

`root@StarBook:/usr/src/linux# /usr/local/bin/ryzenadj -i CPU Family: Cezanne SMU BIOS Interface Version: 19 Version: v0.15.0 PM Table Version: 400005 Name Value Parameter
STAPM LIMIT 15.000 stapm-limit
STAPM VALUE 2.841
PPT LIMIT FAST 30.000 fast-limit
PPT VALUE FAST 3.844
PPT LIMIT SLOW 25.000 slow-limit
PPT VALUE SLOW 2.749
StapmTimeConst 150.000 stapm-time
SlowPPTTimeConst 5.000 slow-time
PPT LIMIT APU 25.000 apu-slow-limit
PPT VALUE APU 2.749
TDC LIMIT VDD 33.000 vrm-current
TDC VALUE VDD 0.332
TDC LIMIT SOC 13.000 vrmsoc-current
TDC VALUE SOC 1.162
EDC LIMIT VDD 90.000 vrmmax-current
EDC VALUE VDD 16.135
EDC LIMIT SOC 17.000 vrmsocmax-current
EDC VALUE SOC 0.000
THM LIMIT CORE 100.000 tctl-temp
THM VALUE CORE 45.875
STT LIMIT APU 0.000 apu-skin-temp
STT VALUE APU 0.000
STT LIMIT dGPU 0.000 dgpu-skin-temp
STT VALUE dGPU 0.000
CCLK Boost SETPOINT 95.000 power-saving /
CCLK BUSY VALUE 12.374 max-performance

`

Sean-StarLabs commented 3 months ago

Did you try the fan curve in the version that you are running?

lil0r commented 3 months ago

Did you try the fan curve in the version that you are running?

running the quite fancurve set in the bios, yes.

Sean-StarLabs commented 3 months ago

And which distro are you using?

evansimo commented 3 months ago

Can confirm similar behaviour. It's not louder than before, the fan just kicks in earlier. I'm on Normal/Standard mode in both BIOS and OS (Fedora 39).

evansimo commented 3 months ago

Another thing I discovered, slightly more annoying. It seems the charge limit set in the BIOS is not respected. Observed yesterday for the first time, confirmed today also. Weirdly, it's unpredictable. I've set it at 80% in the BIOS.

It was stuck at 80% all morning today as expected - then started charging all of a sudden. Now it's reached 93%, and for whatever reason it stopped by itself.

@Sean-StarLabs Let me know if you want me to create a new issue, or perhaps we can rename this one.

Sean-StarLabs commented 3 months ago

What versions?

alternateved commented 3 months ago

I observe similar behaviour as @evansimo in regards to charging. Version for firmware is 24.3.0.

Sean-StarLabs commented 3 months ago

EC, BIOS or both?

evansimo commented 3 months ago

For me it's both

Sean-StarLabs commented 3 months ago

Okay, happens post S3 maybe?

evansimo commented 3 months ago

Good question. No - laptop was shut down, and it's been on, uninterrupted since this morning

Sean-StarLabs commented 3 months ago

Hmm, happening now? Are you able to provide an EC dump? (ectool -d)

evansimo commented 3 months ago

It's gone up to 94 since my last message, and it stopped again. As if some charge is slowly creeping in...

I tried to install ectools and succeeded, but the ectool command is not available. Do you know if there's an easy way to do it on Fedora 39?

alternateved commented 3 months ago

My battery went to 96% and is currently stuck, but I've rebooted half an hour ago so that data might be useless. My dump here on Fedora Beta 40:

EC RAM:

00: 18 03 00 00 01 00 00 00 00 00 00 00 00 00 00 00 
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
30: 00 bb aa 00 00 00 bb 00 00 00 00 00 00 00 00 00 
40: 00 31 36 2f 33 33 2f 35 34 00 00 32 30 32 34 2f 
50: 30 33 2f 31 39 00 00 00 00 00 00 00 00 00 00 00 
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
70: 36 4d 00 00 16 01 00 00 00 05 00 00 00 00 00 01 
80: 07 01 05 01 fc 15 1e 2d a5 16 00 00 08 00 00 d9 
90: 15 ed 32 60 00 17 00 00 00 00 00 00 00 00 00 00 
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
b0: 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 

Ectool installed like so:

git clone http://review.coreboot.org/coreboot.git
cd coreboot/util/ectool
make
sudo make install
# Instead of installing binary on your system you could just run compiled ectool from this directory like so
sudo ./ectool -d

I've also noticed after upgrade to 24.03 that in order to wake laptop from suspend I need to use power button. Before any key would be enough.

Sean-StarLabs commented 3 months ago

might be useless.

Maybe.

10: 00 00 00 00 00 00 00 00 00 00 [00] 00 00 00 00 00 

00 is 100%, bb is 80% and aa is 60% - so the EC is doing what it's been told to do. Is it still set to 80% in AMI?

I've also noticed after upgrade to 24.03 that in order to wake laptop from suspend I need to use power button. Before any key would be enough.

Yes, that was changed in the common code a little while ago, it saves power. Lid can also wake.

alternateved commented 3 months ago

00 is 100%, bb is 80% and aa is 60% - so the EC is doing what it's been told to do. Is it still set to 80% in AMI?

Yup, it surely is.

2024-04-04-165115

Yes, that was changed in the common code a little while ago, it saves power. Lid can also wake.

That's great!

Sean-StarLabs commented 3 months ago

Cheers

Did you install it recently? Just as most of the EC memory is zeroed, and only the old EC used to do that

alternateved commented 3 months ago

Hmm, fwupdmgr get-history displays Last modified: 2024-04-02 18:04 so maybe that was the time. I don't remember exactly. That update showed up in Gnome Software recently and I've installed it.

rmsthebest commented 3 months ago

Since this is becoming a catch-all issue for 24.03 amd fw update, I also have a question. This release is the first that got tagged with "Issues found using FwHunt from Binarly" on LVFS.

I have held off updating for this reason. Is it an old issue only getting tagged now/false positive/nothing to worry about?

alternateved commented 3 months ago

I've noticed that charge limit is not working anymore. Tested it with 80% and 60% limits and the cap does nothing.

Sean-StarLabs commented 2 months ago

Fixed in 24.04