StarLabsLtd / firmware

78 stars 5 forks source link

[StarLite Mk V] Add option to disable extremely bright led's #214

Closed DevenBL closed 1 week ago

DevenBL commented 1 month ago

Please add an option in the bios or somewhere else to disable the external led's

Sean-StarLabs commented 1 month ago

Which ones? Why?

DevenBL commented 1 month ago

The top LED near the power button is extremely bright at night. To have it either solid or pulsating makes sleep difficult if the tablet is on or suspended in the same room. Potentially the charging port led as well although that does not currently seem to be as much of an issue.

alondrayona commented 1 month ago

+1, I don't want to disable, but it would be nice to dim it. It would be best to have an option to set the maximum brightness (e.g. free number input, or a list of predefined values (0,10,...100%), etc.)

Anachron commented 1 month ago

I agree. I wish all devices that can be used in the sleeping room can have their LEDs turned down/off.

Sean-StarLabs commented 1 month ago

Do you care if it does the "breathing"? It'll be possible to do, but I don't know how off the top of my head. Simple on/off for S3 with limited brightness is easy.

mixmastamyk commented 1 month ago

Yes, too bright and too white. Dim and/or orange/red would be better.

Unfortunately I also use it to know how long I've held the power button (blinks at 2 secs I think) to get it to come out of suspend. So please allow the blink to happen even if you have a setting to turn it off.

Also, yes the breathing can be an issue as well. Just curl up with the tablet at night and you'll see. ;-)

alondrayona commented 1 month ago

With breathing would be best, but not mandatory.

gzagatti commented 2 weeks ago

It would be great to be able to adjust this light. It is indeed too bright.

If no customization is possible, I would at least like to be able to switch it off completely as it is very distracting.

DevenBL commented 2 weeks ago

An option to make the light not on all the time/not at max brightness seems to be the common point here. Some people however seem to want to retain the information conveyed by the light. Although i do not particularly care about the specifics of the implementation: Perhaps the option should be to have the power button light normally off and only communicate information through light when pressed?

Fundamentally the problem is that the lights are on all or most of the time. Whatever solution you pick so long as there is an option to have the lights are on less in some way shape or form it would be an improvement. What even is the best practice for this? On the steamdeck valve just allows you to turn the led off and you do things blindly. However since the led is also used when updating the firmware you would likely not want to disable the triple flash functionality when upgrading.

Sean-StarLabs commented 1 week ago

Fixed with 6287b93e88154b7013df782a2e57405f403af339