search

StarLabsLtd / firmware

78 stars 5 forks source link

switch-branch: No supported devices #24

Closed athyla closed 2 years ago

athyla commented 2 years ago

Hello!

I'm not sure if this is the right place to post this issue. I've been trying to install coreboot onto a StarBook Mk V, following the official guide. For some reason, I can't switch branch from AMI to coreboot.

user@starbook:~$ fwupdmgr switch-branch 
No supported devices

I am using Linux Mint 20.2 Cinnamon Edge, with the StarLabs PPA added. I also tried the same steps using a live Ubuntu 21.10, the result is the same.

Here is the output of the commands I used:

user@starbook:~$ fwupdmgr --version 
client version: 1.7.4
compile-time dependency versions
    gusb:   0.3.5

daemon version: 1.7.4
user@starbook:~$ fwupdmgr refresh --force
Updating lvfs
Downloading…             [***************************************]
Downloading…             [***************************************]
Successfully downloaded new metadata: 2 local devices supported
user@starbook:~$ fwupdmgr switch-branch 
No supported devices
user@starbook:~$ fwupdmgr update 
Devices with no available firmware updates: 
 • Star Drive PCIe SSD
 • StarBook
 • UEFI Device Firmware
 • UEFI dbx
Devices with the latest available firmware version:
 • SuperIO FuSuperioIt89Device
 • System Firmware

Any help is appreciated! Thanks!

Sean-StarLabs commented 2 years ago

Hey

Can you let me know the output of these two commands please: upower -i /org/freedesktop/UPower/devices/battery_BAT0 | grep 'state\|percentage' fwupdmgr security --force | grep BIOS

athyla commented 2 years ago

Here you go:

user@starbook:~$ upower -i /org/freedesktop/UPower/devices/battery_BAT0 | grep 'state\|percentage'
    state:               charging
    percentage:          97%
user@starbook:~$  fwupdmgr security --force | grep BIOS
✘ SPI BIOS region:               Unlocked
smiggiddy commented 2 years ago

I'm having this issue as well:

    ~  upower -i /org/freedesktop/UPower/devices/battery_BAT0 | grep 'state\|percentage'
    state:               charging
    percentage:          88%
    ~  fwupdmgr security --force | grep BIOS                                      ✔ 
✘ SPI BIOS region:               Unlocked
Brudibert commented 2 years ago

Same Issue here. Starbook was plugged in while attempting the update. `fwupdmgr --version  ✔ client version: 1.7.3-40-g935e92d0 compile-time dependency versions gusb: 0.3.8

daemon version: 1.7.3-40-g935e92d0    ~  upower -i /org/freedesktop/UPower/devices/battery_BAT0 | grep 'state|percentage'  INT ✘ state: discharging percentage: 98%    ~  fwupdmgr security --force | grep BIOS  ✔ ✘ SPI BIOS Descriptor: Invalid ✘ SPI BIOS region: Unlocked 2021-12-24 14:33:01: ✘ SPI BIOS Descriptor appeared: Invalid`

athyla commented 2 years ago

Hello again!

Since last time I have installed Fedora 35 Workstation. It has fwupdmgr version 1.7.3. The results are the same as initially reported.

Sean-StarLabs commented 2 years ago

If you re-run fwupdmgr refresh --force, it should now find a valid coreboot release.

@athyla For Fedora, you'll need to build flashrom from source as the packaged version isn't new enough to support the 11th Generation processors.

Brudibert commented 2 years ago

On Linux Mint 20.2 I was able to update the Embedded Controller to 1.03 but it still says that Coreboot 7.4 is the latest release. Kernel Version: 5.13.0-23-generic fwupdmgr version: 1.7.4

athyla commented 2 years ago

If you re-run fwupdmgr refresh --force, it should now find a valid coreboot release.

@athyla For Fedora, you'll need to build flashrom from source as the packaged version isn't new enough to support the 11th Generation processors.

Hey Sean, thanks for your reply!

On Fedora I have flashrom version 1.2-7 and fwupdmgr version 1.7.3. I have the same result: No supported devices.

I have tried the process again using two live distros: Manjaro Gnome edition and Linux Mint Edge, both the latest version. On Manjaro I have installed the starlabs version for fwupd and flashrom, on Mint I have used the ppa. Unfortunately I wasn't able to switch-branch, the message is the same for both: No supported devices.

Is there anything else I could do at this point to help?

Sean-StarLabs commented 2 years ago

Could you let me know the output of fwupdmgr get-releases --allow-branch-switch --force for the StarBook device?

athyla commented 2 years ago

I have 2 devices in the list to choose from, SuperIO FuSuperioIt89Device and System Firmware. I have chosen System Firmware.

This is the output:

StarBook
│
├─StarBook MkV:
│     New version:        2
│     Remote ID:          lvfs
│     Release ID:         10607
│     Summary:            AMI firmware for StarBook MkV
│     License:            Proprietary
│     Size:               11.5 MB
│     Created:            2021-11-08
│     Urgency:            Medium
│     Vendor:             Star Labs
│     Flags:              is-downgrade|blocked-version
│     Description:        
│     This stable release includes the following features:
│     
│     • Updated Verb Table
│     • New option to set the maximum battery charge level
│     • Fixed ACPI error
│     • Remember Fn Lock state between reboot
│   
└─StarBook MkV:
      New version:        1
      Remote ID:          lvfs
      Release ID:         10124
      Summary:            AMI firmware for StarBook MkV
      License:            Proprietary
      Size:               11.5 MB
      Created:            2021-09-27
      Urgency:            Medium
      Vendor:             Star Labs
      Flags:              is-downgrade|blocked-version
      Description:        
      This stable release includes the following features:

      • Initial release firmware for the StarBook Mk V
      • American Megatrends Inc:        5.29
      • (CS)Management Engine:      15.0.30.1776
      • Microcode:                      0x88
      • Firmware Support Package:       A.0.51.31

I also inspected the output of dmesg, only 2 things caught my eyes, lines in red in the terminal, these can sometimes be briefly noticed at boot time too, I've seen this with multiple distros:

...
pci 0000:00:07.0: DPC: RP PIO log size 0 is invalid
...
tpm tpm0: [Firmware Bug]: TPM interrupt not working, polling instead
...

But I think these are not related.

Sean-StarLabs commented 2 years ago

Thanks - so the issue is that the device isn't appearing (System Firmware is only used for AMI capsule updates).

Was that on Fedora? It might be that it doesn't have flashrom support, could you run fwupdtool get-devices --plugins flashrom and let me know the output?

athyla commented 2 years ago

Yes, I'm on Fedora 35 now, but I can try with a live Linux Mint if needed, or some other live medium, just let me know.

user@starbook:~$ fwupdmgr get-devices --plugins flashrom
Failed to parse arguments: Unknown option --plugins
user@starbook:~$ fwupdmgr get-plugins 
acpi_dmar:
  Flags:                • Enabled

acpi_facp:
  Flags:                • Enabled

acpi_phat:
  Flags:                • Disabled

amt:
  Flags:                • Disabled

analogix:
  Flags:                • Enabled

ata:
  Flags:                • Enabled

bcm57xx:
  Flags:                • Enabled

bios:
  Flags:                • Disabled

ccgx:
  Flags:                • Enabled

colorhug:
  Flags:                • Enabled

cpu:
  Flags:                • Enabled

cros_ec:
  Flags:                • Enabled

dell_dock:
  Flags:                • Enabled

dell_esrt:
  Flags:                • Disabled
                        • Required hardware was not found

dfu:
  Flags:                • Enabled

dfu_csr:
  Flags:                • Enabled

ebitdo:
  Flags:                • Enabled

elanfp:
  Flags:                • Enabled

elantp:
  Flags:                • Enabled

emmc:
  Flags:                • Enabled

ep963x:
  Flags:                • Enabled

fastboot:
  Flags:                • Enabled

flashrom:
  Flags:                • Enabled

fresco_pd:
  Flags:                • Enabled

goodixmoc:
  Flags:                • Enabled

hailuck:
  Flags:                • Enabled

iommu:
  Flags:                • Enabled

jabra:
  Flags:                • Enabled

lenovo_thinklmi:
  Flags:                • Disabled
                        • Required hardware was not found

linux_lockdown:
  Flags:                • Enabled

linux_sleep:
  Flags:                • Enabled

linux_swap:
  Flags:                • Enabled

linux_tainted:
  Flags:                • Enabled

logind:
  Flags:                • Enabled

logitech_bulkcontroller:
  Flags:                • Enabled

logitech_hidpp:
  Flags:                • Enabled

modem_manager:
  Flags:                • Enabled

mtd:
  Flags:                • Enabled

nitrokey:
  Flags:                • Enabled

nordic_hid:
  Flags:                • Enabled

nvme:
  Flags:                • Enabled

optionrom:
  Flags:                • Enabled

parade_lspcon:
  Flags:                • Enabled

pci_bcr:
  Flags:                • Enabled

pci_mei:
  Flags:                • Enabled

pixart_rf:
  Flags:                • Enabled

realtek_mst:
  Flags:                • Enabled

redfish:
  Flags:                • Disabled

rts54hid:
  Flags:                • Enabled

rts54hub:
  Flags:                • Enabled

steelseries:
  Flags:                • Enabled

superio:
  Flags:                • Enabled

synaptics_cape:
  Flags:                • Enabled

synaptics_cxaudio:
  Flags:                • Enabled

synaptics_mst:
  Flags:                • Enabled

synaptics_prometheus:
  Flags:                • Enabled

synaptics_rmi:
  Flags:                • Enabled

system76_launch:
  Flags:                • Enabled

thelio_io:
  Flags:                • Enabled

thunderbolt:
  Flags:                • Enabled

tpm:
  Flags:                • Enabled

uefi_dbx:
  Flags:                • Enabled

uefi_pk:
  Flags:                • Enabled

upower:
  Flags:                • Enabled

vli:
  Flags:                • Enabled

wacom_raw:
  Flags:                • Enabled

wacom_usb:
  Flags:                • Enabled

msr:
  Flags:                • Enabled

uefi_capsule:
  Flags:                • Enabled

dell:
  Flags:                • Disabled
                        • Required hardware was not found

uefi_recovery:
Sean-StarLabs commented 2 years ago

Thanks, and what does sudo flashrom -p internal show?

athyla commented 2 years ago 
user@starbook:~$ sudo flashrom -p internal
flashrom v1.2 on Linux 5.15.12-200.fc35.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
No DMI table found.
WARNING: No chipset found. Flash detection will most likely fail.
========================================================================
You may be running flashrom on an unknown laptop. We could not
detect this for sure because your vendor has not set up the SMBIOS
tables correctly. Some internal buses have been disabled for
safety reasons. You can enforce using all buses by adding
  -p internal:laptop=this_is_not_a_laptop
to the command line, but please read the following warning if you
are not sure.

Laptops, notebooks and netbooks are difficult to support and we
recommend to use the vendor flashing utility. The embedded controller
(EC) in these machines often interacts badly with flashing.
See the manpage and https://flashrom.org/Laptops for details.

If flash is shared with the EC, erase is guaranteed to brick your laptop
and write may brick your laptop.
Read and probe may irritate your EC and cause fan failure, backlight
failure and sudden poweroff.
You have been warned.
========================================================================
No EEPROM/flash device found.
Note: flashrom can never write if the flash chip isn't found automatically.
Sean-StarLabs commented 2 years ago

Thanks. That version of flashrom isn't new enough to support the 11th Generation processors; if you build the latest one from source, that should do it :)

smiggiddy commented 2 years ago

Hey Sean,

is that the issue with manjaro too?

   ~  sudo flashrom -p internal  ✔ [sudo] password for smig: flashrom v1.2 on Linux 5.15.12-1-MANJARO (x86_64) flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Cannot open file stream for /dev/mtd0 coreboot table found at 0x76b33000. Found chipset "Intel Tiger Lake U Premium". Enabling flash write... Warning: Setting BIOS Control at 0xdc from 0x8b to 0x89 failed. New value is 0x8b. Error accessing SPIBAR, 0x1000 bytes at 0x00000000fe010000 /dev/mem mmap failed: Operation not permitted FAILED! FATAL ERROR! Error: Programmer initialization failed.

Sean-StarLabs commented 2 years ago

No, that just needs the iomem=relaxed kernel parameter. The two below commands will do this for you:

sudo sed -i 's/quiet/quiet iomem=relaxed/g' /etc/default/grub
sudo update-grub
athyla commented 2 years ago

Alright, so I removed the default flashrom package and built the latest version from github. Version is: flashrom v1.2-566-gb5dc741 on Linux 5.15.12-200.fc35.x86_64 (x86_64)

I did the refresh and then the switch-branch and it started to switch to coreboot, showing a warning and asking for confirmation. I have chosen No to bail out of the switch. I wanted to check the same on a live Linux Mint.

I checked the whole process on a live mint, updated the system, built flashrom from git, but it still did not work (No supported device).

I came back to Fedora to do the switch, but this time all the way through and to my surprise I get the initial error: No supported devices. :scream: I have rebuilt flashrom again, refreshed with force, same issue. This is very strange, is there a way to clean/reset fwupd and related things? :disappointed:

Sean-StarLabs commented 2 years ago

fwupd doesn't have much that you can reset, the only thing that upsets it is using sudo.

Can you send me the output of fwupdmgr get-devices from Fedora, whilst it's saying no supported devices?

athyla commented 2 years ago 
user@starbook:~$ fwupdmgr get-devices 
StarBook
│
├─Star Drive PCIe SSD:
│     Device ID:          9aa3cbcc566d62d70c8e5aea851719da50f07ca8
│     Summary:            NVM Express solid state drive
│     Current version:    EIFM21.2
│     Vendor:             Phison Electronics Corporation (NVME:0x1987)
│     GUIDs:              c9465066-32bb-50c5-8338-6a750cae2a44
│                         b1fcba59-6797-58bd-af77-5ccb9be2493c
│                         fcc92585-8e8e-52a3-90cc-6c022b7f3843
│                         59639c7d-1b5d-5b7f-82da-9fd6b369a461
│                         12d61493-5ac4-57f7-a2c5-96878d115455
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs shutdown after installation
│                         • Device is usable for the duration of the update
│   
├─SuperIO FuSuperioIt89Device:
│     Device ID:          3ecf3fbe07ed8933226b294c8c19f4f9c8ebd71a
│     Summary:            Embedded controller
│     Current version:    01.01
│     Vendor:             DMI:Star Labs
│     Install Duration:   20 seconds
│     GUIDs:              049060b5-5010-5ca0-8002-07923951d15e
│                         d83a4cd0-fce6-58a8-93c7-bcee89b41dcf
│     Device Flags:       • Internal device
│                         • Updatable
│                         • Update requires a reboot
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Cryptographic hash verification is available
│   
├─System Firmware:
│ │   Device ID:          a45df35ac0e948ee180fe216a5f703f32dda163f
│ │   Summary:            UEFI ESRT device
│ │   Current version:    33554432
│ │   Minimum Version:    33554432
│ │   Vendor:             Star Labs (DMI:American Megatrends International, LLC.)
│ │   Update State:       Success
│ │   GUIDs:              e27d9e98-cbb2-4975-a8f8-261de2adde05
│ │                       230c8b18-8d9b-53ec-838b-6cfc0383493a
│ │                       51c09ad0-818b-5dc7-9a0f-12253ce64670
│ │   Device Flags:       • Internal device
│ │                       • Updatable
│ │                       • System requires external power source
│ │                       • Supported on remote server
│ │                       • Needs a reboot after installation
│ │                       • Cryptographic hash verification is available
│ │                       • Device is usable for the duration of the update
│ │ 
│ └─UEFI dbx:
│       Device ID:        362301da643102b9f38477387e2193e57abaa590
│       Summary:          UEFI revocation database
│       Current version:  77
│       Minimum Version:  77
│       Vendor:           UEFI:Linux Foundation
│       Install Duration: 1 second
│       GUIDs:            c6682ade-b5ec-57c4-b687-676351208742
│                         f8ba2887-9411-5c36-9cee-88995bb39731
│       Device Flags:     • Internal device
│                         • Updatable
│                         • Needs a reboot after installation
│                         • Only version upgrades are allowed
│     
├─UEFI Device Firmware:
│     Device ID:          349bb341230b1a86e5effe7dfe4337e1590227bd
│     Summary:            UEFI ESRT device
│     Current version:    1
│     Vendor:             DMI:American Megatrends International, LLC.
│     Update State:       Success
│     GUIDs:              eed54281-1c11-4358-bf5a-f64995fbf11b
│                         2b549001-ce65-5243-9056-7cb5214b9302
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
└─USB4 host controller:
      Device ID:          9f0039a80056f8e5d3da1adb71e273f11e4b9ecc
      Summary:            Unmatched performance for high-speed I/O
      Update Error:       No vendor ID set
      GUID:               e72e778e-94f7-5ed2-b560-1c1262ee217c
      Device Flags:       • Internal device
                          • System requires external power source
Sean-StarLabs commented 2 years ago

How very strange. What does sudo flashrom -p internal say now?

athyla commented 2 years ago 
user@starbook:~$ sudo flashrom -p internal
flashrom v1.2-566-gb5dc741 on Linux 5.15.12-200.fc35.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
No DMI table found.
Found chipset "Intel Tiger Lake U Premium".
Enabling flash write... SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-only.
FREG2: Management Engine region (0x00001000-0x004fffff) is read-only.
Not all flash regions are freely accessible by flashrom. This is most likely
due to an active ME. Please see https://flashrom.org/ME for details.
At least some flash regions are write protected. For write operations,
you should use a flash layout and include only writable regions. See
manpage for more details.
Enabling hardware sequencing because some important opcode is locked.
OK.
Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000.
No operations were specified.
Sean-StarLabs commented 2 years ago

Thanks, last one: sudo fwupdtool get-devices --verbose --plugins flashrom --allow-branch-switch

athyla commented 2 years ago

:sweat_smile: I just removed fwupd using dnf with all its dependencies and then installed it again and now I don't get the No supported devices message:

user@starbook:~$ fwupdmgr switch-branch 
Selected device: StarBook
╔══════════════════════════════════════════════════════════════════════════════╗
║ Switch branch from default to coreboot?                                      ║
╠══════════════════════════════════════════════════════════════════════════════╣
║ This stable release includes the following features:                         ║
║                                                                              ║
║ • Update GPIOs                                                               ║
║ • Update CNVi GPIOs                                                          ║
║ • Update trackpad GPIO                                                       ║
║ • Enable TPM_IRQ GPIO                                                        ║
║ • Don't configure ESPI GPIOs                                                 ║
║ • Disconnect unused GPIO's                                                   ║
║ • Add comments for GPIOs                                                     ║
║ • Remove display from devicetree                                             ║
║ • Apply EC settings when suspending                                          ║
║ • Unify EC and CMOS names                                                    ║
║ • Adjust KBL configuration                                                   ║
║ • Enable I2C4                                                                ║
║ • Convert EC_GPE_SCI to Kconfig                                              ║
╚══════════════════════════════════════════════════════════════════════════════╝

Do you understand the consequences of changing the firmware branch? [y|N]: 
Declined branch switch

I answered No again to bail out, ran the fwupd commands again, rebooted, ran the commands again and it is still offering to do the switch, so it seems to be okay now.

Before I do the switch all the way, here is the output of the fwupdtool command:

user@starbook:~$ sudo fwupdtool get-devices --verbose --plugins flashrom --allow-branch-switch
14:11:07:0793 FuDebug              Verbose debugging enabled (on console 1)
14:11:07:0794 FuMain               locked /run/lock/fwupdtool
14:11:07:0800 FuConfig             loading config values from /etc/fwupd/daemon.conf
14:11:07:0800 FuConfig             using autodetected max archive size 18.4 EB
14:11:07:0801 GLib-GIO             _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
14:11:07:0801 FuRemoteList         loading /usr/share/fwupd/metainfo
14:11:07:0850 XbSilo               attempting to load /var/cache/fwupd/metainfo.xmlb
14:11:07:0850 XbSilo               file: b42e572c-f5e2-9544-989f-dc9ff77a2d8c, current:b42e572c-f5e2-9544-989f-dc9ff77a2d8c, cached: (null)
14:11:07:0850 XbSilo               loading silo with file contents
14:11:07:0850 FuRemoteList         loading remote from /etc/fwupd/remotes.d/dell-esrt.conf
14:11:07:0850 FuRemoteList         loading remote from /etc/fwupd/remotes.d/lvfs-testing.conf
14:11:07:0851 FuRemoteList         loading remote from /etc/fwupd/remotes.d/lvfs.conf
14:11:07:0851 FuRemoteList         loading remote from /etc/fwupd/remotes.d/vendor-directory.conf
14:11:07:0851 FuRemoteList         loading remote from /etc/fwupd/remotes.d/vendor.conf
14:11:07:0851 FuRemoteList         skipping invalid file /var/lib/fwupd/remotes.d/lvfs
14:11:07:0851 FuRemoteList         ordering lvfs-testing=lvfs+1
14:11:07:0851 FuRemoteList         ignoring unfound remote fwupd
14:11:07:0851 Jcat                 ignoring GPG-KEY-Linux-Foundation-Firmware as not PKCS-7 certificate
14:11:07:0851 Jcat                 ignoring GPG-KEY-Linux-Vendor-Firmware-Service as not PKCS-7 certificate
14:11:07:0851 Jcat                 trying to load certificate from /etc/pki/fwupd/LVFS-CA.pem
14:11:07:0851 Jcat                 reading /etc/pki/fwupd/LVFS-CA.pem with 1679 bytes
14:11:07:0851 Jcat                 loaded 1 certificates
14:11:07:0851 Jcat                 ignoring GPG-KEY-Linux-Foundation-Metadata as not PKCS-7 certificate
14:11:07:0852 Jcat                 ignoring GPG-KEY-Linux-Vendor-Firmware-Service as not PKCS-7 certificate
14:11:07:0852 Jcat                 trying to load certificate from /etc/pki/fwupd-metadata/LVFS-CA.pem
14:11:07:0852 Jcat                 reading /etc/pki/fwupd-metadata/LVFS-CA.pem with 1679 bytes
14:11:07:0852 Jcat                 loaded 1 certificates
14:11:07:0852 Jcat                 reading /var/lib/fwupd/pki/secret.key with 2455 bytes
14:11:07:0852 Jcat                 reading /var/lib/fwupd/pki/client.pem with 1383 bytes
14:11:07:0852 FuEngine             client certificate now exists: nothing to do
14:11:07:0852 FuHistory            trying to open database '/var/lib/fwupd/pending.db'
14:11:07:0852 FuHistory            got schema version of 7
14:11:07:0852 FuSmbios             trying to read /sys/class/dmi/id
14:11:07:0853 FuHwids              loading HwId overrides from /etc/fwupd/daemon.conf
14:11:07:0853 FuHwids              not loading HwId overrides from /var/lib/fwupd/daemon.conf
14:11:07:0853 FuHwids              smbios property Manufacturer=Star Labs
14:11:07:0853 FuHwids              smbios property EnclosureKind=a
14:11:07:0853 FuHwids              smbios property Family=B5
14:11:07:0853 FuHwids              smbios property ProductName=StarBook
14:11:07:0853 FuHwids              smbios property ProductSku=B5
14:11:07:0853 FuHwids              smbios property BiosVendor=American Megatrends International, LLC.
14:11:07:0853 FuHwids              smbios property BiosVersion=V2.0.00
14:11:07:0853 FuHwids              smbios property BiosMajorRelease=05
14:11:07:0853 FuHwids              smbios property BiosMinorRelease=13
14:11:07:0853 FuHwids              smbios property FirmwareMajorRelease=01
14:11:07:0853 FuHwids              smbios property FirmwareMinorRelease=01
14:11:07:0853 FuHwids              smbios property BaseboardManufacturer=Star Labs
14:11:07:0853 FuHwids              smbios property BaseboardProduct=StarBook
14:11:07:0861 XbSilo               attempting to load /var/cache/fwupd/quirks.xmlb
14:11:07:0861 XbSilo               file: 23242c98-6377-161c-02df-5b5c0747f2d5, current:23242c98-6377-161c-02df-5b5c0747f2d5, cached: (null)
14:11:07:0861 XbSilo               loading silo with file contents
14:11:07:0867 XbSilo               attempting to load /var/cache/fwupd/metadata.xmlb
14:11:07:0867 XbSilo               file: cfd8e7e6-8eea-9f6a-8721-b7a1f4b6ece1, current:cfd8e7e6-8eea-9f6a-8721-b7a1f4b6ece1, cached: (null)
14:11:07:0867 XbSilo               loading silo with file contents
14:11:07:0868 FuEngine             1231 components now in silo
14:11:07:0875 FuPlugin             init(/usr/lib64/fwupd-plugins-5/libfu_plugin_flashrom.so)
14:11:07:0875 FuEngine             plugins disabled: modem_manager, acpi_dmar, acpi_facp, acpi_phat, amt, analogix, ata, bcm57xx, bios, ccgx, colorhug, cpu, cros_ec, dell, dell_dock, dell_esrt, dfu, dfu_csr, ebitdo, elanfp, elantp, emmc, ep963x, fastboot, fresco_pd, goodixmoc, hailuck, invalid, iommu, jabra, lenovo_thinklmi, linux_lockdown, linux_sleep, linux_swap, linux_tainted, logind, logitech_bulkcontroller, logitech_hidpp, msr, mtd, nitrokey, nordic_hid, nvme, optionrom, parade_lspcon, pci_bcr, pci_mei, pixart_rf, realtek_mst, redfish, rts54hid, rts54hub, steelseries, superio, synaptics_cape, synaptics_cxaudio, synaptics_mst, synaptics_prometheus, synaptics_rmi, system76_launch, test, test_ble, thelio_io, thunderbolt, tpm, uefi_capsule, uefi_dbx, uefi_pk, uefi_recovery, upower, vli, wacom_raw, wacom_usb
14:11:07:0875 FuEngine             enabling flashrom due to HwId 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0876 FuEngine             enabling flashrom due to HwId 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0876 FuContext            battery threshold now 30
14:11:07:0876 FuEngine             Emitting PropertyChanged('Status'='loading')
Loading…                 [-                                      ]14:11:07:0876 FuPlugin             startup(flashrom)
14:11:07:0876 FuPlugin             coldplug(flashrom)
14:11:07:0876 FuDevice             no FuContext assigned for FuFlashromInternalDevice:
  Protocol:             org.flashrom
  Flags:                internal|updatable|require-ac|needs-shutdown

14:11:07:0876 FuDevice             converted 'V2.0.00' to '2.0.00'
14:11:07:0877 FuDevice             using dbee8bd3b1ae0316ad143336155651eedb495a0e for flashrom:bios
14:11:07:0877 FuPlugin             emit added from flashrom: dbee8bd3b1ae0316ad143336155651eedb495a0e
14:11:07:0882 FuEngine             requirement 1.7.0 ge 1.7.3 -> org.freedesktop.fwupd passed
14:11:07:0882 FuEngine             HWID provided 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0882 FuDeviceList         ::added dbee8bd3b1ae0316ad143336155651eedb495a0e
14:11:07:0883 FuMain               ADDED:
FuFlashromInternalDevice:
  DeviceId:             dbee8bd3b1ae0316ad143336155651eedb495a0e
  Name:                 StarBook
  Guid:                 230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
  Guid:                 7c13a5b2-22f8-5564-8b48-4bbf20da8ed6 ← Star Labs&B5&StarBook&B5&Star Labs&StarBook
  Guid:                 e327ada1-c062-536b-a1bd-3dcfca48e390 ← Star Labs&B5&StarBook&B5
  Guid:                 b7a2bed5-186f-5643-a96a-0ac51de16c41 ← Star Labs&B5&StarBook
  Guid:                 372a7618-7117-5c3d-b0ea-a67d4e351893 ← Star Labs&B5&Star Labs&StarBook
  Guid:                 612d0af2-6b4b-5d1a-bd63-433022fdaefe ← Star Labs&B5&StarBook&B5&American Megatrends International, LLC.
  Plugin:               flashrom
  Protocol:             org.flashrom
  Flags:                internal|updatable|require-ac|supported|registered|needs-shutdown|has-multiple-branches
  Vendor:               Star Labs
  VendorId:             DMI:American Megatrends International, LLC.
  Version:              2.0.00
  VersionFormat:        triplet
  Icon:                 computer
  Created:              2022-01-07
  PhysicalId:           flashrom
  LogicalId:            bios
  FirmwareSizeMax:      16777216
  InternalFlags:        ensure-semver

14:11:07:0883 FuEngine             requirement 1.7.0 ge 1.7.3 -> org.freedesktop.fwupd passed
14:11:07:0883 FuEngine             HWID provided 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0883 FuEngine             using plugins: flashrom
14:11:07:0892 FuEngine             Emitting PropertyChanged('Status'='idle')
Loading…                 [***************************************]
14:11:07:0893 FuEngine             requirement 1.7.0 ge 1.7.3 -> org.freedesktop.fwupd passed
14:11:07:0893 FuEngine             HWID provided 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0893 FuEngine             client does not understand branches, skipping coreboot:7.91
14:11:07:0894 FuEngine             requirement 1.7.0 ge 1.7.3 -> org.freedesktop.fwupd passed
14:11:07:0894 FuEngine             HWID provided 85aba599-addd-5985-a2e8-eddb41c61ba3
14:11:07:0894 FuEngine             client does not understand branches, skipping coreboot:7.91
14:11:07:0894 FuCommon             creating path /var/cache/fwupd/motd.d
14:11:07:0894 FuEngine             writing motd target /var/cache/fwupd/motd.d/85-fwupd
14:11:07:0894 FuMain               FuFlashromInternalDevice:
  DeviceId:             dbee8bd3b1ae0316ad143336155651eedb495a0e
  Name:                 StarBook
  Guid:                 230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
  Guid:                 7c13a5b2-22f8-5564-8b48-4bbf20da8ed6 ← Star Labs&B5&StarBook&B5&Star Labs&StarBook
  Guid:                 e327ada1-c062-536b-a1bd-3dcfca48e390 ← Star Labs&B5&StarBook&B5
  Guid:                 b7a2bed5-186f-5643-a96a-0ac51de16c41 ← Star Labs&B5&StarBook
  Guid:                 372a7618-7117-5c3d-b0ea-a67d4e351893 ← Star Labs&B5&Star Labs&StarBook
  Guid:                 612d0af2-6b4b-5d1a-bd63-433022fdaefe ← Star Labs&B5&StarBook&B5&American Megatrends International, LLC.
  Plugin:               flashrom
  Protocol:             org.flashrom
  Flags:                internal|updatable|require-ac|supported|registered|needs-shutdown|has-multiple-branches
  Vendor:               Star Labs
  VendorId:             DMI:American Megatrends International, LLC.
  Version:              2.0.00
  VersionFormat:        triplet
  Icon:                 computer
  Created:              2022-01-07

I'm not sure what was it, I checked for system updates, there were none.

EDIT: there was a difference this time, when doing the refresh, it downloaded metadata for 3 devices, instead of 2 as it was before.

user@starbook:~$ fwupdmgr refresh --force
Updating lvfs
Downloading…             [***************************************]
Successfully downloaded new metadata: 3 local devices supported
athyla commented 2 years ago

Alright, so I went ahead to do the switch, but it wasn't able to finish the process, here is the output:

user@starbook:~$ fwupdmgr refresh --force
Updating lvfs
Downloading…             [***************************************]
Successfully downloaded new metadata: 3 local devices supported
user@starbook:~$ fwupdmgr switch-branch 
Selected device: StarBook
╔══════════════════════════════════════════════════════════════════════════════╗
║ Switch branch from default to coreboot?                                      ║
╠══════════════════════════════════════════════════════════════════════════════╣
║ This stable release includes the following features:                         ║
║                                                                              ║
║ • Update GPIOs                                                               ║
║ • Update CNVi GPIOs                                                          ║
║ • Update trackpad GPIO                                                       ║
║ • Enable TPM_IRQ GPIO                                                        ║
║ • Don't configure ESPI GPIOs                                                 ║
║ • Disconnect unused GPIO's                                                   ║
║ • Add comments for GPIOs                                                     ║
║ • Remove display from devicetree                                             ║
║ • Apply EC settings when suspending                                          ║
║ • Unify EC and CMOS names                                                    ║
║ • Adjust KBL configuration                                                   ║
║ • Enable I2C4                                                                ║
║ • Convert EC_GPE_SCI to Kconfig                                              ║
╚══════════════════════════════════════════════════════════════════════════════╝

Do you understand the consequences of changing the firmware branch? [y|N]: y
╔══════════════════════════════════════════════════════════════════════════════╗
║ Upgrade StarBook from 2.0.00 to 7.91?                                        ║
╠══════════════════════════════════════════════════════════════════════════════╣
║ This stable release includes the following features:                         ║
║                                                                              ║
║ • Update GPIOs                                                               ║
║ • Update CNVi GPIOs                                                          ║
║ • Update trackpad GPIO                                                       ║
║ • Enable TPM_IRQ GPIO                                                        ║
║ • Don't configure ESPI GPIOs                                                 ║
║ • Disconnect unused GPIO's                                                   ║
║ • Add comments for GPIOs                                                     ║
║ • Remove display from devicetree                                             ║
║ • Apply EC settings when suspending                                          ║
║ • Unify EC and CMOS names                                                    ║
║ • Adjust KBL configuration                                                   ║
║ • Enable I2C4                                                                ║
║ • Convert EC_GPE_SCI to Kconfig                                              ║
║                                                                              ║
║ StarBook and all connected devices may not be usable while updating.         ║
╚══════════════════════════════════════════════════════════════════════════════╝

Perform operation? [Y|n]: 
Downloading…             [***************************************]
Downloading…             [**                                     ] Less than one Downloading…             [**                                     ] Less than one Downloading…             [***                                    ] Less than one Downloading…             [***                                    ] Less than one Downloading…             [***                                    ] Less than one Downloading…             [****                                   ] Less than one Downloading…             [****                                   ] Less than one Downloading…             [*****                                  ] Less than one Downloading…             [*****                                  ] Less than one Downloading…             [***************************************]
Decompressing…           [***************************************]
Decompressing…           [***************************************]
Authenticating…          [***************************************]
Authenticating…          [***************************************]
failed to open device for prepare: flash probe failed: no chip was found
kciredor commented 2 years ago

That is - if I understand correctly - due to sudo flashrom -p internal outputting 'No chipset found', right?

What I don't get myself is how flashrom 1.2 is almost 2 years old and there's still differences in 1.2 versions across distro's?

athyla commented 2 years ago

That is - if I understand correctly - due to sudo flashrom -p internal outputting 'No chipset found', right?

What I don't get myself is how flashrom 1.2 is almost 2 years old and there's still differences in 1.2 versions across distro's?

Hey @kciredor! Since I have built the latest version of flashrom from git, it finds the chipset:

user@starbook:~$ sudo flashrom -p internal
flashrom v1.2-566-gb5dc741 on Linux 5.15.12-200.fc35.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
No DMI table found.
Found chipset "Intel Tiger Lake U Premium".
Enabling flash write... SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-only.
FREG2: Management Engine region (0x00001000-0x004fffff) is read-only.
Not all flash regions are freely accessible by flashrom. This is most likely
due to an active ME. Please see https://flashrom.org/ME for details.
At least some flash regions are write protected. For write operations,
you should use a flash layout and include only writable regions. See
manpage for more details.
Enabling hardware sequencing because some important opcode is locked.
OK.
Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000.
No operations were specified.
Sean-StarLabs commented 2 years ago

@kciredor Yes, no chip was found is basically flashrom is too old.

flashrom hasn't tagged a release in about 2 years, the all the distros are just intermittently building versions from master to try and solve problems like this. I'll give them another nudge, see if they're planning to do it anytime soon...

@athyla Let me set one up with Fedora to try and figure out what's going on...

athyla commented 2 years ago

Thanks, @Sean-StarLabs! Btw, what OS are you normally using with the StarLabs HW?

Sean-StarLabs commented 2 years ago

Mostly Ubuntu, but I spend a lot of time with elementary and Manjaro

kciredor commented 2 years ago

Would it be safe to use an Ubuntu live CD for firmware updates for me?

(Because NixOS is quite a battle to get fwupd/flashrom updated/packaged)

Sean-StarLabs commented 2 years ago

Yup, 20.04 or 21.04, just run:

sudo add-apt-repository ppa:starlabs/ppa
sudo add-apt-repository universe
sudo apt update
sudo apt full-upgrade -y
sudo apt install fwupd
sudo apt -f install
fwupdmgr refresh --force
fwupdmgr switch-branch
kciredor commented 2 years ago

Managed to build custom flashrom on NixOS, would you say this looks about right / safe to use? (I'm currently on Coreboot 7.4 as it was shipped to me, unable to build fwupd on NixOS yet).

$ sudo flashrom -p internal

flashrom 1.2-custom on Linux 5.10.89 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
Cannot open file stream for /dev/mtd0
coreboot table found at 0x76b33000.
Found chipset "Intel Tiger Lake U Premium".
Enabling flash write... Warning: Setting BIOS Control at 0xdc from 0x8b to 0x89 failed.
New value is 0x8b.
SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-only.
FREG2: Management Engine region (0x00001000-0x004fffff) is read-only.
Not all flash regions are freely accessible by flashrom. This is most likely
due to an active ME. Please see https://flashrom.org/ME for details.
At least some flash regions are write protected. For write operations,
you should use a flash layout and include only writable regions. See
manpage for more details.
OK.
Found Programmer flash chip "Opaque flash chip" (16384 kB, Programmer-specific) mapped at physical address 0x0000000000000000.
No operations were specified.
Sean-StarLabs commented 2 years ago

Yes, looks good to me

kciredor commented 2 years ago

This is what's used by fwupd to flash coreboot right? Meaning I could use it without fwupd and run it manually to flash coreboot upgrades for now?

Sean-StarLabs commented 2 years ago

Yes, fwupd basically just runs a flashrom command. - sudo flashrom -p internal -w coreboot.rom -i bios --ifd -N

fwupd does also make sure it's done correctly i.e. power is connected, it'll shutdown after flashing and that it's the right file

smiggiddy commented 2 years ago

What's the latest stable coreboot firmware?

kciredor commented 2 years ago

Now that I'm thinking about it, can it be used to flash the NVME and other Chipset (I'm on 1.0.1 and there is 1.0.3 now) as well?

kciredor commented 2 years ago

@smiggiddy 7.91 for StarBook Mk V -> https://github.com/StarLabsLtd/firmware

Sean-StarLabs commented 2 years ago

No, both of those use other tools - flashing them manually is complicated and erroneous.

kciredor commented 2 years ago

Thanks for everything @Sean-StarLabs. Just want to make sure one more thing: fwupd does not depend on anything else, to be able to flash those other things, right? It is batteries included except for Coreboot flashing specifically where it needs flashrom?

Sean-StarLabs commented 2 years ago

That's right :)

kciredor commented 2 years ago

I've proceeded with an Ubuntu live cd following your instructions. Except for "fwupdmgr switch-branch" which I've replaced with "fwupdmgr update", because I was already on Coreboot (7.4) and trying to upgrade to 7.91. At the end of the updates it requests to shutdown the laptop which I did.

Then I turned it on again and now my laptop does not boot anymore saying:

Booting from 'NVMe: Star Drive PCIe SSD ' failed; verify it contains a 64-bit UEFI OS.

Press any key to continue booting...

After pressing enter I end up in UEFI interactive shell which I immediately 'exit' and then the UEFI options menu shows me FW: 7.91 01/04/2022 which means the upgrade has been completed I guess.

Looking through the boot manager items there is the StarBook NVMe and UEFI. The NVMe entry results in the boot error about a missing 64-bit UEFI OS.

I've now added my own boot entry pointing directly to the grub file in EFI on SSD and that allows me to boot my system again. Then I moved this up in the boot order so it's default now.

Is it normal for Coreboot not to boot my OS anymore without manual intervention after a firmware upgrade? And did I do the right thing?

Running fmupdmgr again (from NixOS quickly, not from live Ubuntu) shows me that the embedded controller is still at 1.01, even though the fwupd process showed me that it was upgraded to 1.03. What did I miss?

danth commented 2 years ago

@kciredor NixOS adds a boot entry for GRUB when it is first installed. Updating Coreboot seems to reset the list of boot entries. I'm also running NixOS on the StarBook, and I've found that Systemd-Boot is picked up automatically even when the list is reset:

boot.loader = {
  efi.canTouchEfiVariables = true;
  systemd-boot.enable = true;
};

(You will need to remove GRUB from the EFI partition manually if you want to switch.)

As for the embedded controller update: NixOS refused to start up until I removed a symlink which fwupd had created at the filesystem root (had to be done from a live USB). After that, NixOS was booting again, but fwupd reported that the update had failed. I'm not sure exactly what the procedure for updating the embedded controller involves, so I can't say why this happens.

kciredor commented 2 years ago

@danth Thanks for the information, makes sense. I'll probably switch to systemd-boot then.

I've run fwupdmgr update from NixOS now to retry upgrading the chipset from 1.01 to 1.03. It said it succeeded and so I rebooted. Then I ran into the same issue as you did so I had to use a live CD to remove the symlink from the root directory (/system-update pointing to /var/lib/fwupd).

I'm guessing something should be running to finalize the update upon boot, but instead it crashes NixOS.

Right now I can boot into NixOS again. My chipset firmware is still at 1.01. And... my trackpad is completely dead :-( It is working with a reboot into Ubuntu live cd though. Super strange.

athyla commented 2 years ago

@kciredor I have tried out the chipset firmware update too, as it was 1.01 on my StarBook too. First I tried it from a live kubuntu and it went as you described, process finished with no error message, it offered to reboot, but after reboot the chipset version was still 1.01. I did this 2 times, same result.

Since then I installed kubuntu on an external drive, but I don't think this makes any difference, besides not needing to add the ppa and update the whole system after every reboot. I tried the firmware update again, it went as before, no errors, but after reboot it was still the old version. Then when listing the devices I noticed, that I wasn't plugged in and updates cannot be done on battery. Strange that it let's you do the update without even a warning that it cannot be done on battery.

Anyways, I tried it again, this time plugged in, this time doing fwupdmgr upgrade instead of fwupdmgr update as I was doing before and after reboot I have had the latest version installed. The help of fwupdmgr says that upgrade is an alias to update, so I'm not sure what was the problem with my first attempts.

kciredor commented 2 years ago

Meanwhile reinstalled NixOS and my trackpad is still dead. I'm assuming something happened with the upgrade attempt to 1.03 which messed up my laptop.

Update: after about 5 minutes the trackpad becomes alive ?! So I have to wait 5 minutes upon every boot for my mouse to work.

athyla commented 2 years ago

@Sean-StarLabs In the meantime I have tried out Kubuntu for a change (21.10), out of curiosity (I'm in a "let's try out a few more ditros" mode :grinning: ). I added the PPA and did the full update as described above. The switch-branch finished successfully this time. :partying_face: I'm not sure why it did not work on Mint.

The system booted normally. I played around a bit, I checked the coreboot menu options and coreboot-configurator. Everything works fine on Kubuntu.

Then I booted Fedora. After installing all the missing dependencies, building coreboot-configurator finished successfully, however the app does not run correctly, it opens and it complains about not finding nvramtool.

I also tried switching back to AMI while on Fedora and it does the same as last time, the update fails with the failed to open device for prepare: flash probe failed: no chip was found message. So there is definitely a problem or something missing on Fedora.

Question: what is holding CTRL-ALT-DEL-POWER doing more exactly?

athyla commented 2 years ago

@kciredor I thought the 5 minutes were only a one-time thing, on every boot it would be very annoying. I haven't experienced this at all, although I haven't tried NixOS, only: Fedora, OpenSuse, Linux Mint, Ubuntu, Kubuntu, Manjaro and EndeavorOS. Perhaps open a separate ticket with your problems, it might be clearer that way. Good luck!

grexe commented 2 years ago

I have the same issue on Manjaro with Starlabs-fwupd, flashrom works (detects the flash chip and successfully flashes with the command posted above), but with fwupdmgr I get the "no devices detected" error. However, with AMI BIOS (not with coreboot), fwupdtool sees 3 local devices and finds an update for the SuperIO device:

Upgrade SuperIO FuSuperioIt89Device from 01.01 to 1.03?

But after a successful update and reboot, it still proposes the same update again, so obviously it either has not really performed the operation, or it does not detect the version correctly.

I have previously flashed coreboot 7.11 because I thought it was newer than 7.91, but I was obviously wrong, so trying with 7.91 again now.