search

StarLabsLtd / firmware

75 stars 5 forks source link

[StarBook Mk VI - AMD] Trouble with s2idle #76

Closed tsmithe closed 1 year ago

tsmithe commented 1 year ago

The platform reports s2idle support in /sys/power/mem_sleep, but attempting to enter suspend causes the system to lock up. Moreover, the amd_pmc module does not load correctly, and the ACPI FADT doesn't seem to report s2idle support. See the comments around here for a little more information: https://gitlab.freedesktop.org/drm/amd/-/issues/2403#note_1774129

I am on the AMI firmware (since coreboot doesn't yet seem to be available, following #65), but if (when it becomes available) switching to coreboot would resolve this bug, that would be fine by me.

superm1 commented 1 year ago

Given https://github.com/StarLabsLtd/firmware/issues/75#issuecomment-1479192461 I think this should be re-opened.

https://gitlab.freedesktop.org/drm/amd/-/blob/master/scripts/amd_s2idle.py will indicate the failures when the BIOS is misconfigured.

Particularly if amd_pmc isn't loading, that means that the ACPI device is not present. Generally on AMD AGESA based systems there is a BIOS option that needs to be changed that affects all the things necessary.

Sean-StarLabs commented 1 year ago

Working on it regardless - about 80% of the way through the dsdt :/

Sean-StarLabs commented 1 year ago

Still testing #d9d7b680fe3aa697fa0368b9d826bb30856358b7 , but disabling ASPM for the wireless might have done the trick

superm1 commented 1 year ago

There's an issue that some newer Intel hardware doesn't support lane switch when transitioning to L0s, so if disabling aspm helps try to just disable L0s to narrow down.