Closed ezaquarii closed 1 year ago
We can't get involved with bsd but reset -s
from the EFI shell should shut it down. Assuming that's what you meant, what EC version are you using?
In EFI shell reset -s
shuts down the system, but blue LEDs are illuminated and laptop drains battery. I can shut it down by pressing power-off button again.
@Sean-StarLabs
# cat /sys/class/dmi/id/ec_firmware_release
1.4
@Sean-StarLabs I found something interesting. When booting Linux and doing halt -p
, the system shuts down correctly and the bug goes away. I can properly shut it down:
reset -s
machine poweroff
halt -p
UNTIL I power-off the machine during boot.
The bug is triggered with the following procedure:
reset -s
leaves system with blue LEDs illuminated, machine poweroff
and halt -p
no longer workhalt -p
to fix the problemIt looks like powering off the system from EFI leaves firmware in some weird state and the state is persisted between power cycles.
8.37
in testing __might help - we're quite limited on XHCI control in coreboot
@Sean-StarLabs 8.37 did not solve the problem. I observed another thing:
halt -p
reset -s
to shutdown (works)halt -p
(works)halt -p
will hang the machine (as well as reset -s
in EFI).Whatever Linux boot process does to the power management, I suspect firmware goes hairy in the background after some time.
Have you tried using shutdown? I wonder if halt doesn't let coreboot know it's going down, so it doesn't reset XHCI
I tested both halt
and shutdown
on OpenBSD and both result in hang. I'll ask on the mailing list to see if there is a way to disable xhci via software.
I could also test if xhci can be disabled in firmware. Is it possible?
I doubt there is; and there isn't one in the firmware.
If you're asking the mailing list; it needs to be requesting S5, if it isn't, it wont do the reset and then in turn, hang.
This problem happens in EFI firmware as well, when issuing reset -s
. Does it perform shutdown via S5?
I can't replicate that; can you make it happen without BSD in the equation?
Does it perform shutdown via S5?
Not sure what you mean?
Yes, when I boot into EFI shell reset -s hangs it.
But as I mentioned in the original report, if you run Linux first and shut down machine from there, it "fixes" it somehow for a while.
I can take a look later if it's possible to trigger that from EFI. I think i did that by doing some hard reset during boot, but need to sit down at home and fiddle with it to give you a detailed procedure.
In the meantime, I propose that you download OpenBSD install img, write it to USB stick. When it boots, it prompts user to run shell or installer. Just choose shell and do halt -p. It should trigger the failure.
When you power it off, try EFI shell reset -s. It should fail as well.
Booting Linux should fix it.
Sorry dude, we don't have the time to try to support BSD as the demand for it is almost non-existent.
Any bug with that out of the equation, I'm more than happy to help
Here is how to trigger the condition:
reset -s
powers off the machinereset -s
hangs the machine from now onhalt -p
to "fix" the problemI have the same problem on Linux 6.3.8: shutdown doesn't turn the machine off completely and I have to hold the power button to do so. I have been encountering this issue since I've updated to the 8.50 BIOS.
@ak-coram It's different, but now fixed in 8.51
- that's going up to the LVFS now so should be available in about 24 hours
@Sean-StarLabs: thanks for the letting me know, does this also fix the issue where it sometimes doesn't come back from sleep (screen doesn't turn on)?
Not aware of such an issue - was that only introduced in 8.50
?
@Sean-StarLabs: I've had it since 8.37, it occurs pretty frequently (about 1 in 3 times) when waking from sleep.
It might be also something from an earlier release, since I've skipped a bunch of updates before 8.37.
There were a few bugs in 8.37
, so maybe. If not, please open a issue
@Sean-StarLabs: okay, thanks!
Can't change this one; coreboot can only enumerate things as PCI devices, which the PMC isn't. Changing that would involving changing how coreboot works.
AMI won't have this issue though
@Sean-StarLabs can you explain what the issue is? it's marked as completed but explaination suggests wontfix?
Long story short, the Power Management Controller isn't accessible, which is needed to turn off the USB controller. coreboot can only handle PCI devices but the PMC on GLK isn't one. It was disabled years ago (https://review.coreboot.org/c/coreboot/+/15530) to get the GPIO controllers working.
So yes, it's a "wontfix", as it would involve rewriting coreboot.
Coreboot 8.24.
Trying to shutdown the machine from Open/Free/NetBSD using
halt -p
hangs it. Shutting it down from coreboot shell (no OS) usingreset
command hangs it. Shutting down from OpenBSD bootloader usingmachine poweroff
hangs it.Shutting down from Linux works, suggesting that it must be related to some early hardware setup.