search

StarPlayrX / CameoKit

HTTP Live Streaming Engine, SiriusXM middleware and framework that I wrote for StarPlayrX.
MIT License
1 stars 2 forks source link

Mac version always 64k #1

Open WizKid64 opened 3 years ago

WizKid64 commented 3 years ago

Using a Mac connected via a Thunderbolt ethernet adapter.

from Sirius Audio/Audio.swift:

[code] switch (net.networkIsWiFi, net.networkIsConnected) {

case (true, true) : bitrate = "256k" case (false, true) : bitrate = "64k" case (_, false): bitrate = "32k" } [/code]

it always gets the 64k stream.

Seems like it should check to see if it's building the Mac building, and i so, always use the 256k stream.

(Soory for using BBcode, the Markdown code stuff I can't get to work).

StarPlayrX commented 2 years ago

Sorry for the late response. I will work on a fix a fix for this.

WizKid64 commented 2 years ago

Also, the "macOS_catalyst" branch of 1.2.2 doesn't build on 10.15. Perhaps you could include checks for each OS version (Catalina/Big Sur)?

The earlier (1.1.5) version builds fine.

Maybe you could provide separate binaries of (I presume) what will be either 1.2.4 or 1.3 (for both Catalina and Big Sur)?

Running Xcode 12.2.

StarPlayrX commented 2 years ago

There are not many users using the Mac version.

I may create menu bar app that works across both Cat and BigSur, which I have been intending on does.

But if I do a Catalyst/M1, it will probably only be in on 11+. And that version will be in the store in apple allows it. It's a pain UI wise unless I think the 10.15 UI iPad is better.