Open goldenbean opened 7 months ago
see detail in https://github.com/StarRocks/starrocks/pull/13330
Thanks for your test and report, we will do a comprehensive testing and analysis
Bravo ! and Glacias :)
see detail in #13330
@stdpain Would you mind to share or opensource your benchmark code in Starrocks? So, I could run it on our latest commercial servers, such as intel Gold 6130, Intel Platinum 8338C and Amd Genova, and give you feedback of what I will get
see detail in #13330
@stdpain Would you mind to share or opensource your benchmark code in Starrocks? So, I could run it on our latest commercial servers, such as intel Gold 6130, Intel Platinum 8338C and Amd Genova, and give you feedback of what I will get
@dirtysalt
We have marked this issue as stale because it has been inactive for 6 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to StarRocks!
Since glibc continues improving its performance a years-long, the latest version of glibc (2.35) delivered from ubuntu 22.04 seems having a better performance than the strings::memcpy_inlined function, which is currently using in Starrocks writen by Google in 2012.
I have done a bunch of tests with different compiler's parameters, as specially with SIMD instructions. Here is the results:
with -mavx2 only, reduce 43% time in average
with -mavx2 and -mavx512f
with no SIMD parameters. It means that the strings::memcpy_inlined function falls back to glibc memcpy, the performance is therefore equivalent to each other.
The tests are based on
Intel Xeon Silver 4214 46Core, 256GB Mem Ubuntu 22.04, gcc 11.4.0, glibc 2.35
test code snippets
CPU Flags