StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.

https://starrocks.io

Apache License 2.0

8.3k stars 1.68k forks source link

[FE] stop services in StarRocksFE.addShutdownHook #46916

Open mingmxu opened 3 weeks ago

mingmxu commented 3 weeks ago

Context

When a FE node is shutdown, the addShutdownHook method flush BDB status. However it doesn't close the QeService/FeServer/HttpServer proactively. This causes problems in client side:

it still can accept new requests;
the running requests are not handled properly which results in long-stuck requests;

improvement

Same as BDB, we need to close the services at the same time. It should not accept new requests, the running requests can be terminated aggressively.

cc @chaoyli

chenminghua8 commented 4 days ago

Is this feature already being worked on? If not, can it be assigned to me?

mingmxu commented 16 hours ago

Is this feature already being worked on? If not, can it be assigned to me?

I don't think anyone is working on it, feel free to take it cc @chaoyli to confirm.