[Feature] Support kill query by custom_query_id

kaijianding commented 3 days ago

Why I'm doing:

User want to set a user generated query id and kill query by the user specified query id

What I'm doing:

Allow set custom query id in session and kill query by this id in all running fe(leader, follower, observer).

Usage:


set custom_query_id=xx;
select ...;

show proc '/current_queries';
kill running query 'xx';

this custom_query_id is temporary, it will be removed from session after select sql is done

Fixes #47699

What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [ ] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5

github-actions[bot] commented 3 days ago

[FE Incremental Coverage Report]

:x: fail : 30 / 64 (46.88%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
:large_blue_circle:	com/starrocks/qe/LeaderOpExecutor.java	0	5	00.00%	[92, 93, 94, 122, 123]
:large_blue_circle:	com/starrocks/qe/ConnectScheduler.java	0	1	00.00%	[182]
:large_blue_circle:	com/starrocks/qe/QueryStatisticsItem.java	0	8	00.00%	[43, 82, 106, 124, 125, 183, 184, 186]
:large_blue_circle:	com/starrocks/qe/ConnectContext.java	2	5	40.00%	[613, 614, 616]
:large_blue_circle:	com/starrocks/qe/StmtExecutor.java	12	24	50.00%	[1005, 1007, 1037, 1040, 1041, 1042, 1044, 1046, 1049, 1051, 1052, 1054]
:large_blue_circle:	com/starrocks/common/proc/CurrentQueryStatisticsProcDir.java	1	2	50.00%	[114]
:large_blue_circle:	com/starrocks/qe/ConnectProcessor.java	5	9	55.56%	[380, 381, 382, 384]
:large_blue_circle:	com/starrocks/sql/parser/AstBuilder.java	6	6	100.00%	[]
:large_blue_circle:	com/starrocks/qe/SessionVariable.java	2	2	100.00%	[]
:large_blue_circle:	com/starrocks/qe/QeProcessorImpl.java	1	1	100.00%	[]
:large_blue_circle:	com/starrocks/sql/ast/AstVisitor.java	1	1	100.00%	[]

imay commented 2 days ago

@kaijianding Do you think the name custom_query_id is more suitable? And I suggest you can split this PR into multi PRs. One is to add new query id. the other is to support kill by this new id.

kaijianding commented 1 hour ago

@kaijianding Do you think the name custom_query_id is more suitable? And I suggest you can split this PR into multi PRs. One is to add new query id. the other is to support kill by this new id.

Done renaming to custom_query_id.

Most codes are about killing query by custom_query_id, i think these code should stay in 1 pr.