StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.
https://starrocks.io
Apache License 2.0
8.26k stars 1.67k forks source link

[Enhancement]still need check on num_row and avail_levels for debug mode fuzz #47637

Closed zombee0 closed 2 days ago

zombee0 commented 3 days ago

Why I'm doing:

without num_rows > avail_levels check, there are a lot of fuzzing tests(illegal parquet files) crash on DCHECK in debug mode. consider that we have limit batch size in upper layer, remove limitation in level decoder and make sure for optional type num_rows >= avail_levels

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

github-actions[bot] commented 3 days ago

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 3 days ago

[BE Incremental Coverage Report]

:white_check_mark: pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/formats/parquet/stored_column_reader.cpp 1 1 100.00% []
zombee0 commented 3 days ago

@Mergify automerge

mergify[bot] commented 3 days ago

automerge

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.