StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.
https://starrocks.io
Apache License 2.0
8.29k stars 1.68k forks source link

[BugFix] Reject rename col which is referenced in rollup (backport #47714) #47770

Closed mergify[bot] closed 2 days ago

mergify[bot] commented 2 days ago

Why I'm doing:

Before renaming a column, delete the associated rollups, just like dropping a column.

What I'm doing:

Fixes #42823

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

What I'm doing:

Fixes #42823

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

mergify[bot] commented 2 days ago

Cherry-pick of 96c0ec212075f79342c22840b986f19420c59fe3 has failed:

On branch mergify/bp/branch-3.1/pr-47714
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 96c0ec2120.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   fe/fe-core/src/main/java/com/starrocks/alter/SchemaChangeHandler.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   fe/fe-core/src/main/java/com/starrocks/alter/AlterJobMgr.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] commented 2 days ago

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr