[BugFix] fix bug of profile crash on ASAN (backport #47737) - Githubissues

StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.

https://starrocks.io

Apache License 2.0

8.74k stars 1.75k forks source link

[BugFix] fix bug of profile crash on ASAN (backport #47737) #47783

Closed mergify[bot] closed 3 months ago

mergify[bot] commented 3 months ago

Why I'm doing:

one driver's profile has its' operators profiles, and store them in:

typedef std::map<std::string, RuntimeProfile*> ChildMap;
    ChildMap _child_map;

so every operator has unique profile name, which is "operator name" + plan node id.

right now group execution(https://github.com/StarRocks/starrocks/pull/44771) can has pipelines below:

scan1->limit1->local exchange sink1
local exchange sourc 4->limit4->join probe4->limit4

the first limit 4 is infered by limit1, they have same limit size, first limit4 can be used for short-circuit

so limit 4 is not unique anymore. so add opeartor id for limit, then pipeline become:

scan1->limit1(14)->local exchange sink1
local exchange sourc 4->limit4(17)->join probe4->limit4(18)

What I'm doing:

Fixes #issue

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [ ] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
  This is an automatic backport of pull request #47737 done by Mergify.
  Why I'm doing:
  
  one driver's profile has its' operators profiles, and store them in:
```
typedef std::map<std::string, RuntimeProfile*> ChildMap;
ChildMap _child_map;
```
  so every operator has unique profile name, which is "operator name" + plan node id.

right now group execution(https://github.com/StarRocks/starrocks/pull/44771) can has pipelines below:

scan1->limit1->local exchange sink1
local exchange sourc 4->limit4->join probe4->limit4

the first limit 4 is infered by limit1, they have same limit size, first limit4 can be used for short-circuit

so limit 4 is not unique anymore. so add opeartor id for limit, then pipeline become:

scan1->limit1(14)->local exchange sink1
local exchange sourc 4->limit4(17)->join probe4->limit4(18)

What I'm doing:

Fixes #issue

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
[x] This is a backport pr

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud