StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.
https://starrocks.io
Apache License 2.0
8.74k stars 1.75k forks source link

[Enhancement] Limit err msg size if there is an exception when converting JSON when loading #47791

Closed srlch closed 2 months ago

srlch commented 3 months ago

Why I'm doing:

If strip_outer_array is true, we may get huge of json err msg if the converting got an exception. It is because simdjson's api can only get raw json string of the entire json array.

What I'm doing:

Limit the err msg when JSON converting got an exception.

Fixes #issue https://github.com/StarRocks/StarRocksTest/issues/7978

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

github-actions[bot] commented 2 months ago

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 2 months ago

[BE Incremental Coverage Report]

:white_check_mark: pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/util/json_converter.cpp 7 7 100.00% []
github-actions[bot] commented 2 months ago

@Mergifyio backport branch-3.3

mergify[bot] commented 2 months ago

backport branch-3.3

✅ Backports have been created

* [#48085 [Enhancement] Limit err msg size if there is an exception when converting JSON when loading (backport #47791)](https://github.com/StarRocks/starrocks/pull/48085) has been created for branch `branch-3.3`
srlch commented 2 months ago

https://github.com/Mergifyio backport branch-3.2

mergify[bot] commented 2 months ago

backport branch-3.2

✅ Backports have been created

* [#48086 [Enhancement] Limit err msg size if there is an exception when converting JSON when loading (backport #47791)](https://github.com/StarRocks/starrocks/pull/48086) has been created for branch `branch-3.2`