StarRocks / starrocks

StarRocks, a Linux Foundation project, is a next-generation sub-second MPP OLAP database for full analytics scenarios, including multi-dimensional analytics, real-time analytics, and ad-hoc queries.
https://starrocks.io
Apache License 2.0
8.29k stars 1.68k forks source link

[BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug #47796

Closed HangyuanLiu closed 2 days ago

HangyuanLiu commented 2 days ago

Why I'm doing:

refer : https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_change_user.html

What I'm doing:

There is an error when parsing the conn_attr field of COM_CHANGE_USER, because that field is the length of the following attr, not the number of attrs. Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 days ago

[FE Incremental Coverage Report]

:white_check_mark: pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/mysql/MysqlChangeUserPacket.java 4 4 100.00% []
github-actions[bot] commented 2 days ago

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 2 days ago

@Mergifyio backport branch-3.3

github-actions[bot] commented 2 days ago

@Mergifyio backport branch-3.2

github-actions[bot] commented 2 days ago

@Mergifyio backport branch-3.1

github-actions[bot] commented 2 days ago

@Mergifyio backport branch-3.0

mergify[bot] commented 2 days ago

backport branch-3.3

✅ Backports have been created

* [#47813 [BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug (backport #47796)](https://github.com/StarRocks/starrocks/pull/47813) has been created for branch `branch-3.3`
github-actions[bot] commented 2 days ago

@Mergifyio backport branch-2.5

mergify[bot] commented 2 days ago

backport branch-3.2

✅ Backports have been created

* [#47814 [BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug (backport #47796)](https://github.com/StarRocks/starrocks/pull/47814) has been created for branch `branch-3.2`
mergify[bot] commented 2 days ago

backport branch-3.1

✅ Backports have been created

* [#47812 [BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug (backport #47796)](https://github.com/StarRocks/starrocks/pull/47812) has been created for branch `branch-3.1`
mergify[bot] commented 2 days ago

backport branch-3.0

✅ Backports have been created

* [#47816 [BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug (backport #47796)](https://github.com/StarRocks/starrocks/pull/47816) has been created for branch `branch-3.0`
mergify[bot] commented 2 days ago

backport branch-2.5

✅ Backports have been created

* [#47815 [BugFix] Fix parse Mysql Client Protocol COM_CHANGE_USER with conn_attr error bug (backport #47796)](https://github.com/StarRocks/starrocks/pull/47815) has been created for branch `branch-2.5`