StarRocks / starrocks

The world's fastest open query engine for sub-second analytics both on and off the data lakehouse. With the flexibility to support nearly any scenario, StarRocks provides best-in-class performance for multi-dimensional analytics, real-time analytics, and ad-hoc queries. A Linux Foundation project.
https://starrocks.io
Apache License 2.0
8.84k stars 1.77k forks source link

in starrocks-3.1.15, I changed WITH_STARCACHE to OFF in build.sh, and the compilation still depends on starcache! #51220

Open loong-hy opened 1 month ago

loong-hy commented 1 month ago

in starrocks-3.1.15, I changed WITH_STARCACHE to OFF in build.sh, and the compilation still depends on starcache!

if [[ -z ${WITH_STARCACHE} ]]; then WITH_STARCACHE=OFF fi

I've already seen WITH_STARCACHE set to OFF via ccmake,But the compilation still reports a missing starcache header file error.

` [ 1%] Building CXX object src/agent/CMakeFiles/Agent.dir/task_worker_pool.cpp.o In file included from /home/beckhuang/workspace/starrocks-3.1.15/be/src/block_cache/block_cache.h:17, from /home/beckhuang/workspace/starrocks-3.1.15/be/src/common/daemon.cpp:39: /home/beckhuang/workspace/starrocks-3.1.15/be/src/block_cache/kv_cache.h:20:10: fatal error: starcache/star_cache.h: No such file or directory 20 | #include "starcache/star_cache.h" | ^~~~~~~~ compilation terminated. make[2]: *** [src/common/CMakeFiles/Common.dir/build.make:76:src/common/CMakeFiles/Common.dir/daemon.cpp.o] 错误 1

`

kevincai commented 1 month ago

@GavinMar do we support to turn off star cache completely on branch-3.1?

rohitrs1983 commented 4 weeks ago

@GavinMardo we support to turn off star cache completely on branch-3.1?

@kevincai https://github.com/StarRocks/starrocks/pull/40599 not present in 3.1.15 branch

loong-hy commented 4 weeks ago

@GavinMardo we support to turn off star cache completely on branch-3.1?

@kevincai #40599 not present in 3.1.15 branch

您好,有回合到3.1分支的计划么?

kevincai commented 4 weeks ago

@loong-hy not right now, can you manually cherry-pick the corresponding PR for your compilation on branch-3.1?

loong-hy commented 4 weeks ago

@loong-hy not right now, can you manually cherry-pick the corresponding PR for your compilation on branch-3.1?

Okay, I'll try.