StarRocks / starrocks

The world's fastest open query engine for sub-second analytics both on and off the data lakehouse. With the flexibility to support nearly any scenario, StarRocks provides best-in-class performance for multi-dimensional analytics, real-time analytics, and ad-hoc queries. A Linux Foundation project.
https://starrocks.io
Apache License 2.0
9.06k stars 1.82k forks source link

[BugFix] Fix hive text reader can't recognize last empty element (backport #52990) #53005

Closed mergify[bot] closed 3 days ago

mergify[bot] commented 3 days ago

Why I'm doing:

User's data is ["1", "2", ""] We will read as ["1", "2"]

What I'm doing:

fix it

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

What I'm doing:

fix it

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

mergify[bot] commented 3 days ago

Cherry-pick of 14d6654838a772846d666d9d34b78b5541f32c9f has failed:

On branch mergify/bp/branch-2.5/pr-52990
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 14d6654838.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    new file:   be/test/exec/test_data/csv_scanner/array_last_element_is_empty.csv

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   be/src/formats/csv/array_reader.cpp
    both modified:   be/test/exec/vectorized/hdfs_scanner_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] commented 3 days ago

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr