StarRocks / starrocks

The world's fastest open query engine for sub-second analytics both on and off the data lakehouse. With the flexibility to support nearly any scenario, StarRocks provides best-in-class performance for multi-dimensional analytics, real-time analytics, and ad-hoc queries. A Linux Foundation project.
https://starrocks.io
Apache License 2.0
9.17k stars 1.82k forks source link

[Refactor] move `getPartitions` API into `icebergCatalog` #53007

Closed dirtysalt closed 4 days ago

dirtysalt commented 6 days ago

Why I'm doing:

For all iceberg catalog implementations, the way to getPartitions are the same:

And with one pass scan, we can get both

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud[bot] commented 4 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-actions[bot] commented 4 days ago

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 4 days ago

[FE Incremental Coverage Report]

:white_check_mark: pass : 88 / 104 (84.62%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: com/starrocks/connector/iceberg/CachingIcebergCatalog.java 18 25 72.00% [94, 203, 204, 261, 262, 386, 387]
:large_blue_circle: com/starrocks/connector/iceberg/IcebergCatalog.java 60 69 86.96% [183, 184, 194, 195, 234, 235, 243, 244, 251]
:large_blue_circle: com/starrocks/connector/iceberg/IcebergMetadata.java 10 10 100.00% []
github-actions[bot] commented 4 days ago

[BE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

dirtysalt commented 3 days ago

@mergify backport branch-3.4

mergify[bot] commented 3 days ago

backport branch-3.4

✅ Backports have been created

* [#53116 [Refactor] move `getPartitions` API into `icebergCatalog` (backport #53007)](https://github.com/StarRocks/starrocks/pull/53116) has been created for branch `branch-3.4`