StarRocks / starrocks

The world's fastest open query engine for sub-second analytics both on and off the data lakehouse. With the flexibility to support nearly any scenario, StarRocks provides best-in-class performance for multi-dimensional analytics, real-time analytics, and ad-hoc queries. A Linux Foundation project.
https://starrocks.io
Apache License 2.0
9.04k stars 1.82k forks source link

[BugFix] Fix show keys from support external catalog (backport #52977) #53027

Closed mergify[bot] closed 2 days ago

mergify[bot] commented 2 days ago

Why I'm doing:

When Power BI connects to external tables, it executes the SHOW KEYS FROM $database.$table statement. This statement is supported for internal tables but not for external tables, resulting in Power BI failing to connect to external tables.

What I'm doing:

To fix this issue, modify the SHOW KEYS FROM statement to take the catalog into account, ensuring that the corresponding database and table can be located properly.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

What I'm doing:

To fix this issue, modify the SHOW KEYS FROM statement to take the catalog into account, ensuring that the corresponding database and table can be located properly.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

mergify[bot] commented 2 days ago

Cherry-pick of c38a6775f426425c1f6b74afffdf06a9d30d2347 has failed:

On branch mergify/bp/branch-3.3/pr-52977
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit c38a6775f4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   fe/fe-core/src/test/java/com/starrocks/qe/ShowExecutorTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] commented 2 days ago

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr