[BugFix] fix the misleading FE thrift rpc fail message (backport #52706)

mergify[bot] commented 2 days ago

it is the frontend fails to make the thrift rpc call. Not the client fails to call frontend's thrift rpc.

Why I'm doing:

2024-11-07 08:10:54.641Z WARN (heartbeat-mgr-pool-1|176) [ThriftRPCRequestExecutor.call():80] Call frontend thrift rpc failed, addr: TNetworkAddress(hostname:127.0.0.1, port:9050), retried: 0
org.apache.thrift.transport.TTransportException: Socket is closed by peer.
        at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:177) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.transport.TTransport.readAll(TTransport.java:100) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:519) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:387) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:271) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79) ~[libthrift-0.20.0.jar:0.20.0]
        at com.starrocks.thrift.HeartbeatService$Client.recv_heartbeat(HeartbeatService.java:64) ~[starrocks-fe.jar:?]
        at com.starrocks.thrift.HeartbeatService$Client.heartbeat(HeartbeatService.java:51) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.lambda$call$0(HeartbeatMgr.java:292) ~[starrocks-fe.jar:?]
        at com.starrocks.rpc.ThriftRPCRequestExecutor.call(ThriftRPCRequestExecutor.java:67) ~[starrocks-fe.jar:?]
        at com.starrocks.rpc.ThriftRPCRequestExecutor.callNoRetry(ThriftRPCRequestExecutor.java:40) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.call(HeartbeatMgr.java:289) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.call(HeartbeatMgr.java:264) ~[starrocks-fe.jar:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
        at java.lang.Thread.run(Thread.java:829) ~[?:?]

TNetworkAddress(hostname:127.0.0.1, port:9050) is actually the BE thrift service port.

What I'm doing:

Fixes #issue

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch
- [x] 3.3
- [x] 3.2
- [ ] 3.1
- [ ] 3.0
- [ ] 2.5
  This is an automatic backport of pull request #52706 done by Mergify.
it is the frontend fails to make the thrift rpc call. Not the client fails to call frontend's thrift rpc.

Why I'm doing:

2024-11-07 08:10:54.641Z WARN (heartbeat-mgr-pool-1|176) [ThriftRPCRequestExecutor.call():80] Call frontend thrift rpc failed, addr: TNetworkAddress(hostname:127.0.0.1, port:9050), retried: 0
org.apache.thrift.transport.TTransportException: Socket is closed by peer.
        at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:177) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.transport.TTransport.readAll(TTransport.java:100) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:519) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:387) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:271) ~[libthrift-0.20.0.jar:0.20.0]
        at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79) ~[libthrift-0.20.0.jar:0.20.0]
        at com.starrocks.thrift.HeartbeatService$Client.recv_heartbeat(HeartbeatService.java:64) ~[starrocks-fe.jar:?]
        at com.starrocks.thrift.HeartbeatService$Client.heartbeat(HeartbeatService.java:51) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.lambda$call$0(HeartbeatMgr.java:292) ~[starrocks-fe.jar:?]
        at com.starrocks.rpc.ThriftRPCRequestExecutor.call(ThriftRPCRequestExecutor.java:67) ~[starrocks-fe.jar:?]
        at com.starrocks.rpc.ThriftRPCRequestExecutor.callNoRetry(ThriftRPCRequestExecutor.java:40) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.call(HeartbeatMgr.java:289) ~[starrocks-fe.jar:?]
        at com.starrocks.system.HeartbeatMgr$BackendHeartbeatHandler.call(HeartbeatMgr.java:264) ~[starrocks-fe.jar:?]
        at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
        at java.lang.Thread.run(Thread.java:829) ~[?:?]

TNetworkAddress(hostname:127.0.0.1, port:9050) is actually the BE thrift service port.

What I'm doing:

Fixes #issue

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
- [ ] I have added documentation for my new feature or new function
[x] This is a backport pr

mergify[bot] commented 2 days ago

Cherry-pick of a41c514df875102b83cb0caf05aa026fe999c5ce has failed:

On branch mergify/bp/branch-3.2/pr-52706
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit a41c514df8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
    deleted by us:   fe/fe-core/src/main/java/com/starrocks/rpc/ThriftRPCRequestExecutor.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] commented 2 days ago

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr