StarRocks / starrocks

The world's fastest open query engine for sub-second analytics both on and off the data lakehouse. With the flexibility to support nearly any scenario, StarRocks provides best-in-class performance for multi-dimensional analytics, real-time analytics, and ad-hoc queries. A Linux Foundation project.
https://starrocks.io
Apache License 2.0
9.04k stars 1.82k forks source link

[Enhancement]avoid Aws::Client::ClientConfiguration default ctor which has a remote access #53061

Closed zombee0 closed 1 day ago

zombee0 commented 1 day ago

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

If yes, please specify the type of change:

Checklist:

Bugfix cherry-pick branch check:

github-actions[bot] commented 1 day ago

[Java-Extensions Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 1 day ago

[FE Incremental Coverage Report]

:white_check_mark: pass : 0 / 0 (0%)

github-actions[bot] commented 1 day ago

[BE Incremental Coverage Report]

:white_check_mark: pass : 15 / 17 (88.24%)

file detail

path covered_line new_line coverage not_covered_line_detail
:large_blue_circle: be/src/fs/fs_s3.cpp 8 10 80.00% [74, 98]
:large_blue_circle: be/src/fs/fs_s3.h 7 7 100.00% []
dirtysalt commented 1 day ago

Can you describe which remote access? w

zombee0 commented 1 day ago

Can you describe which remote access? w

let me show u code in default ClientConfiguration ctor: `ClientConfiguration::ClientConfiguration() { this->disableIMDS = false; setLegacyClientConfigurationParameters(*this); retryStrategy = InitRetryStrategy();

if (!this->disableIMDS &&
    region.empty() &&
    Aws::Utils::StringUtils::ToLower(Aws::Environment::GetEnv("AWS_EC2_METADATA_DISABLED").c_str()) != "true")
{
    auto client = Aws::Internal::GetEC2MetadataClient();
    if (client)
    {
        region = client->GetCurrentRegion();
    }
}
if (!region.empty())
{
    return;
}
region = Aws::String(Aws::Region::US_EAST_1);
setConfigFromEnvOrProfile(*this);

}`

github-actions[bot] commented 1 day ago

@Mergifyio backport branch-3.4

mergify[bot] commented 1 day ago

backport branch-3.4

✅ Backports have been created

* [#53089 [Enhancement]avoid Aws::Client::ClientConfiguration default ctor which has a remote access (backport #53061)](https://github.com/StarRocks/starrocks/pull/53089) has been created for branch `branch-3.4`