Migrate data lookup

[wrycu]

It looks like data access for entities has changed in v10 and it's causing issues.

From creating an actor:

Error: You are accessing the ActorFFG#data object which is no longer used. Since V10 the Document class and its contained DataModel are merged into a combined data structure. You should now reference keys which were previously contained within the data object directly.

You are accessing ActorFFG#data which has been migrated to ActorFFG#system Deprecated since Version 10

Error: TextEditor.enrichHTML is becoming asynchronous. In the short term you may pass async=true or async=false as an option to nominate your preferred behavior. Deprecated since Version 10

[Esrin]

Tackled a bunch of these. There's lots left, although they're all deprecation warnings rather than total fails.

Haven't even looked at the importers yet but I imagine they're probably a bit dire.

[wrycu]

Items don't generate warnings anymore, and I've migrated some actor calls. known issues as of the above commit:

• [ ] item attachment --> "add mods" results in an error (this was present in v9 as well)
• [ ] item attachment --> tweaking mods results in some errors where you can't update them
• [x] ship weapon --> modifying special doesn't properly retrieve the current value
• [x] signature ability --> modifying text doesn't properly retrieve the current value
• [x] specializations are broken
  • creating a specialization results in two errors and doesn't open it, but it does successfully create it
  • you cannot edit individual nodes in the specialization
• [x] cannot attach attachments to weapons
• [x] cannot attach qualities to weapons
• [x] putting items into a ship adds two and then exceeds the max recursion depth

[Esrin]

These commits look good @wrycu ... get a PR in to the v10 branch! I'm also gonna add you to the main repo so it's a bit easier for you to work on this going forward.

[wrycu]

okay, current status:

• fixed attachments on weapons from compendium

  • reintroduced .data call when adding an attachment to a weapon from a compendium (this will generate a warning)

• fixed importers

• fixed remaining system call on drag-and-drop for adversaries

• fixed qualities missing their ranks - cannot be viewed or set

• fixed settings UI using old .data calls

• fixed swa importer

• fixed embeddeditem helpers

• haven't tested migrating a world yet

• drag-and-drop macro creation is still using .data

• item qualities linked in chat open but the content isn't loaded (not sure why)

• item attachment --> "add mods" results in an error (this was present in v9 as well)

• item attachment --> tweaking mods results in some errors where you can't update them

[wrycu]

opened https://github.com/StarWarsFoundryVTT/StarWarsFFG/pull/1079. Once I get the content working for links, I'll start deving directly in this repo (but I think we'll be in a fairly good place for a v10 alpha release)