search

StarWarsFoundryVTT / StarWarsFFG

StarWarsFFG System for Foundry VTT.
http://www.foundryvtt.com
MIT License
93 stars 77 forks source link

Improved TextEditor enrichers for nested tag parsing #1578

Closed sparradee closed 3 weeks ago

sparradee commented 1 month ago

Updates the RegExp used when processing tags ([B], etc); allows the processor to properly convert nested tags (e.g., [B]Average ([di][di]) check[b].

Side thought: it may not even be necessary to worry about enclosing many of these tags (from [B]...[b] to <b>...</b>) -- you could probably just do a straight [B] -> <b> / [b] -> </b> and it'll be fine.

wrycu commented 3 weeks ago

@sparradee sorry for the delay here, I don't get email notifications for new PRs unless I'm directly assigned. Can you please update the changelog with a summary of the changes you've implemented here? I reviewed them and they look good.

sparradee commented 3 weeks ago

@sparradee sorry for the delay here, I don't get email notifications for new PRs unless I'm directly assigned. Can you please update the changelog with a summary of the changes you've implemented here? I reviewed them and they look good.

Done. This also presumes a "1.902" tag in the changelog.

wrycu commented 3 weeks ago

Appreciate the changes.

I think you asked on the other PR, but no, there are no SCSS files for the Mandar theme.

I'm also not fantastic at CSS; if you have other theming improvements, do feel free to either suggest them or simply implement them (though a mock up in an issue or on Discord might help prevent wasted effort.)