search

StarWarsFoundryVTT / StarWarsFFG

StarWarsFFG System for Foundry VTT.
http://www.foundryvtt.com
MIT License
93 stars 79 forks source link

Group Manage Access Lost #444

Closed TGreyfeather closed 3 years ago

TGreyfeather commented 4 years ago

After clicking on Group Manager and clicking off, I am no longer able to activate the group manager from the toolbar in version 0.7.6. Rolled back to 0.7.5 and I can once again access Group Manager on demand.

Sonny-Crockett commented 3 years ago

I have this issue, got this from my Console:

foundry.js:12183 Uncaught TypeError: Cannot set property 'visible' of null at GroupManagerLayer.activate (foundry.js:12183) at GroupManagerLayer.activate (foundry.js:40143) at GroupManagerLayer.activate (groupmanager-ffg.js:16) at SceneControls._onClickLayer (foundry.js:19863) at HTMLLIElement.dispatch (jquery.min.js:2) at HTMLLIElement.v.handle (jquery.min.js:2)

cstadther commented 3 years ago

Fixed in dev branch, will be in 1.2 release.

TGreyfeather commented 3 years ago

Tested Dev branch and am still having the same issue. Fairly certain I installed it correctly as I have other new features working (can move the Destiny Pool Tool).

cstadther commented 3 years ago

Thanks for taking the time to test it on the Dev Branch. Can you provide the steps you're using to get it to stop displaying?

TGreyfeather commented 3 years ago

Same as before:

Currently using Foundry 0.7.8

Happy to help out however I can. Really love your work!!!

cstadther commented 3 years ago

Cool thanks... was able to replicate the issue. Working on a fix.

cstadther commented 3 years ago

Actually I found a couple issue with how the Group Manager is placed as a scene button. I'm moved it to a button on the Destiny Tracker for GM's only.

TGreyfeather commented 3 years ago

That works for me. Pulled and tested Dev branch ... working great. Like the additional features to add and remove FPs.

The only thing that would make it better - and this is a super minor thing - is if it remembered its location on restart.

Thanks so much for all the work. This has been great for my games!

From: Chris Stadther notifications@github.com Sent: Sunday, December 13, 2020 3:55 PM To: StarWarsFoundryVTT/StarWarsFFG StarWarsFFG@noreply.github.com Cc: TGreyfeather rpankuch@hotmail.com; Author author@noreply.github.com Subject: Re: [StarWarsFoundryVTT/StarWarsFFG] Group Manage Access Lost (#444)

Actually I found a couple issue with how the Group Manager is placed as a scene button. I'm moved it to a button on the Destiny Tracker for GM's only.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FStarWarsFoundryVTT%2FStarWarsFFG%2Fissues%2F444%23issuecomment-744067068&data=04%7C01%7C%7C1ddaee265b3441158d4908d89fa95eaf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637434897068725888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JOk6q4iZL3ibr8msVA3tuwCVPMh22SqJkJ6lh9GpOkI%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARXELPQXPFG2SAAAJ5AXR53SUUS2RANCNFSM4TSWRVGQ&data=04%7C01%7C%7C1ddaee265b3441158d4908d89fa95eaf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637434897068735845%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FHfFmbj86EKRYwi9zULSj4tyyDZoc%2FtOP%2FBIrBo1Ai4%3D&reserved=0.