StarWarsFoundryVTT / StarWarsFFG

StarWarsFFG System for Foundry VTT.
http://www.foundryvtt.com
MIT License
93 stars 78 forks source link

Vehicle Ship Attachments show up as Cargo Hold Items not as Attachments/Weaponry #861

Closed florianpiekert closed 10 months ago

florianpiekert commented 3 years ago

Before 1.4 I used self created vehicle items (shipattchments/shopweapon) and they showed up on the vehicle sheet where they supposed to be (Attachments/Weaponry).

After updating to 1.4 and reimporting the oggdude dataset I wanted to switch to the item-imports from oggdude.VehicleWeapons and oggdude.itemAttachments, but they show up as Freight, not as what they are supposed to be.

The Vehicle weapons shows in the Ship Weapons section, but the Ship Attachments shows up as Cargo Hold Items. So that should be logged as a bug. I'm guessing that they are imported as the wrong type of objects. That's the issue, if you create your own shipattachment item, and drag on the ship, it shows in the correct section.

MarsMage commented 3 years ago

I'm 99% sure this isn't a bug. Using the imported ship attachments isn't supported yet

wrycu commented 10 months ago

This was fixed at some point.

benjibromberg commented 7 months ago

I'm still having the issue that @florianpiekert explained on the latest release of the foundry mod with the most recent oggdude dataset

Seems that the default import {"type"} in the oggdude json files is itemattachement not shipattachmentwhich seems to be used by this mod

It seems that ship attachments can be identified from item attachments during import by {"system": {"type": "vehicle"}} or by {"img": "/systems/starwarsffg/images/mod-vehicle.png"} since only using {"type"} as an identifier will make everything an itemattachment