StarbeamOne / home

Basic central repository for issue-tracking and documentation (wiki)
MIT License
2 stars 0 forks source link

Pre-mobile optimizations: grids #126

Open ujmappa opened 1 year ago

ujmappa commented 1 year ago

While grids are great and I confirm that these work on mobile as well, they are pretty difficult to maintain in bootstrap, so as first step I suggest to remove them where possible covering two main parts:

If there is any other usage of grids, please let me know, I identified these three.

Mike-E-angelo commented 1 year ago

When you say grids you mean bootstrap grids of the 12-divisions kind? If so I additionally complicated it up front with another control toolkit that uses its own flavor, and used that for a while, thinking it was a better solution, when in fact it was not necessary at all. 😬

ujmappa commented 1 year ago

When you say grids you mean bootstrap grids of the 12-divisions kind? If so I additionally complicated it up front with another control toolkit that uses its own flavor, and used that for a while, thinking it was a better solution, when in fact it was not necessary at all. 😬

I mean that non-tile mode in case of inventory, user list, etc. With the client-side filters...

Mike-E-angelo commented 1 year ago

Ah those are Syncfusion grids and most of the work managing is already taken care of ATM :)

There is a lot of functionality in there, replacing them would be non-trivial as we'd have to take the built-in LINQ-parsing/filtering and essentially create/manage it custom code.

ujmappa commented 1 year ago

Ah those are Syncfusion grids and most of the work managing is already taken care of ATM :)

There is a lot of functionality in there, replacing them would be non-trivial as we'd have to take the built-in LINQ-parsing/filtering and essentially create/manage it custom code.

Mmm. In case of images replacement of it would take literally nothing, just removing one switch. In case of users the same tile handling should be added like in inventory items, so it should not be a big deal. In case of history it's a bigger change, but basically it would be fetching all the same data and show it in some other view.

You see, maintaining that view in bootstrap for mobile is a big deal, a lot bigger than to replace them with simple bootstrap controls. Point one and two are a few hours of jobs. Point three is not that big of a deal on the server side.. More in the generated HTML, but after one is done (maybe one day of a job), it's pretty straightforward.

ujmappa commented 1 year ago

But now you also made me curious about that "another control toolkit". Where can I find that? Because it should be removed :D

Mike-E-angelo commented 1 year ago

Those tasks are simple but how are we going to preserve filtering/sorting which is very good along with a built-in Excel-type filter control which I find very powerful/handy :)

Mike-E-angelo commented 1 year ago

Because it should be removed :D

Nodding along and if it were easy like that I would have done it long ago. But you cannot simply remove you have to replace which means preserving existing functionality and that nothing is broken in both desktop + mobile. There are platform considerations as well between browsers.

ATM it is "if it ain't broken don't fix it" until we have the monies to do a full sweep v2 (future).

But to answer your question we are using Radzen, MatBlazor, and Syncfusion.

I'd rather remove everything but Syncfusion who support their product incredibly well.

Mike-E-angelo commented 1 year ago

Also I am not sure what you mean by manage bootstrap grids being a big deal I spend very little time w/ Bootstrap and in fact it's one of the easier parts about the UX :)

ujmappa commented 1 year ago

Those tasks are simple but how are we going to preserve filtering/sorting which is very good along with a built-in Excel-type filter control which I find very powerful/handy :)

You do not need them for history and users. You might need them for the inventory and definitions filtering status (and maybe a quick search for the titles).

ujmappa commented 1 year ago

Also I am not sure what you mean by manage bootstrap grids being a big deal I spend very little time w/ Bootstrap and in fact it's one of the easier parts about the UX :)

I'm sorry, maybe there is a missunderstanding here. I don't want them to be replaced by bootstrap grids. My proposal was to replace them with tiles and history with bootstrap timeline. No bootstrap grids were involved, those are tricky bastards.