search

Starbow / erosd

The ladder server
GNU General Public License v3.0
6 stars 5 forks source link

Getting undefined: skills.NewPlayer on build #5

Closed sebneira closed 10 years ago

sebneira commented 10 years ago

I'm having some trouble building the server:

$ go install github.com/Starbow/erosd
# github.com/Starbow/erosd
src/github.com/Starbow/erosd/ladder.go:575: undefined: skills.NewPlayer
src/github.com/Starbow/erosd/ladder.go:576: undefined: skills.NewPlayer
src/github.com/Starbow/erosd/matchmaking.go:147: undefined: skills.NewPlayer

What am I doing wrong?

Veritasimo commented 10 years ago

You'll have to pull in the TrueSkill library we use.

go get github.com/ChrisHines/GoSkills

Veritasimo commented 10 years ago

Did you place it in your GOPATH src directory?

sebneira commented 10 years ago

go get github.com/ChrisHines/GoSkills/skills would have done it, isn't it so?

Just in case I'm misunderstanding (I'm fairly new to Go):

$ ls $GOPATH/src/github.com/ChrisHines
GoSkills
Veritasimo commented 10 years ago

https://github.com/ChrisHines/GoSkills/commit/4bf12a67cd23fc8dd162cd389c1d6378fd531c03

This commit probably has something to do with it. It seems he removed the internal Player type (which was pointless to begin with). You can pull a commit from before then or wait until I patch it.

sebneira commented 10 years ago

ITS ALIIIIIVE! Thanks a ton Veritas, seems that's the issue :)

I'll worked on a detached head until it gets patched.

PS: I'll contact you soon regarding the sockets and what info comes/goes for the web client.

Veritasimo commented 10 years ago

I just patched the server. Feel free to pull.

I was working on adding websockets to the project at one point. It'd probably be easier to use the existing protocol buffers, assuming Javascript supports them.

sebneira commented 10 years ago

I’ve been looking for protocol buffers on javascript but haven’t find any relevant info other than those related to websockets. I’ll keep on searching and will see what we can do.

On June 30, 2014 at 10:32:25 AM, Josh (notifications@github.com) wrote:

I just patched the server. Feel free to pull.

I was working on adding websockets to the project at one point. It'd probably be easier to use the existing protocol buffers, assuming Javascript supports them.

— Reply to this email directly or view it on GitHub.

Veritasimo commented 10 years ago

Ideally Websockets would be the way we want to go. HTTP polling would be pretty crap.

sebneira commented 10 years ago

I’m on the same foot on that. Anyway, I won’t be able to do much the following next weeks, so there’s no rush on that.

On June 30, 2014 at 10:40:40 AM, Josh (notifications@github.com) wrote:

Ideally Websockets would be the way we want to go. HTTP polling would be pretty shitty.

— Reply to this email directly or view it on GitHub.

Veritasimo commented 10 years ago

Ok, cool. I'm always around in the Skype chats if you need more help.