startLinking incorrectly uses EntityPlayerSP in singleplayer worlds

Starchasers / OCGlasses

mod for minecraft and addon for Open Computers

zlib License

30 stars 17 forks source link

startLinking incorrectly uses EntityPlayerSP in singleplayer worlds #69

Closed Faeranne closed 5 years ago

Faeranne commented 5 years ago

Minecraft Version: 1.12.2 Forge Version: 14.23.5.2768 Java Version: 11.0.1 2018-10-16 LTS OCGlasses Version: 2.1.1-17

When using the command startLinking and passing a username, the command responds with net.minecraft.client.entity.EntityPlayerSP cannot be cast to net.minecraft.client.entity.EntityPlayerMP and fails. Seems to be related to how getPlayer in the clientproxy fetches the player.

When used in a server, everything works as expected.

ben-mkiv commented 5 years ago

thanks for the report, here is a fixed version http://ci.pc-logix.com/job/OCGlasses/18/artifact/build/libs/OpenGlasses-MC1.12.2-2.1.1-18.jar

Faeranne commented 5 years ago

Looks like it works! You have really been knocking these fixes out of the park. Thanks for the dedication!