search

Starchasers / OCGlasses

mod for minecraft and addon for Open Computers
zlib License
31 stars 17 forks source link

[Bug] Incompatible with Immersive Vehicles #77

Closed nrllewellyn closed 4 years ago

nrllewellyn commented 4 years ago

Describe the bug Installing OCGlasses prevents Immersive Vehicles' controls screen form displaying.

In which environment did the Bug appear? Single Player and Dedicated Server

To Reproduce Steps to reproduce the behavior:

  1. Install OCGlasses and Immersive Vehicles
  2. Try to open the Open Vehicles controls screen

Expected behavior Controls screen should open

Screenshots / Code Snippet N/A

Minecraft:

Additional context Bug will be cross-posted to Immersive Vehicle's Github, and I will post a link shortly.

nrllewellyn commented 4 years ago

Issue in Immersive Vehicle's Github: https://github.com/DonBruce64/MinecraftTransportSimulator/issues/199

nrllewellyn commented 4 years ago

Note: This appears to be an issue with the way one of the mods does keybindings, as with both mods installed the keybinding for Immersive Vehicles controls is labeled as "Glasses Config" in the controls menu.

nrllewellyn commented 4 years ago

With OCGlasses installed: 2019-10-13_02 43 27

nrllewellyn commented 4 years ago

Without OCGlasses installed: 2019-10-13_02 45 08

ben-mkiv commented 4 years ago

both mods, screwed up their translation keys.

DonBruce64 commented 4 years ago

Yup, that's a bad on my end. I have the lang file set to "key.config", so that explains why it would conflict with your mod. I swore I got everything converted to use my modID as a prefix in the lang file after I had conflicts with block names, but I guess I missed the controls. Still shouldn't keep the user from opening the config, though, as the binding has a separate category. He should see two "Config Glasses" sections, one under MTS and one under OCG. Unless Forge's keybindings don't care about category and only care about the binding name....

Currently in the process of re-writing my mod for less pain to update to 1.14.4, so I won't be able to get to this for a while. Will let you know when I do.

ben-mkiv commented 4 years ago

I've uploaded a fixed version of OpenGlasses (2.2-38) to Curse/Twitch

DonBruce64 commented 4 years ago

Should close the loop and say V15.4.0 of my mod has corrected this on my end as well.