Starcommander / StreamRadio

Play network-radio channels, and add your custom channels.
GNU General Public License v3.0
19 stars 8 forks source link

Proposal new logo for WebRadio #4

Closed rezamusic881 closed 5 years ago

rezamusic881 commented 6 years ago

Hi admin, I want to offer a new logo design is more sweet and simple application for WebRadio If you like and can accept it.

You can simply reply to this proposal, I will gladly send you a new logo this file and I was able to provide some variation for this app, thank you!

webradioooo

no-go commented 5 years ago

Hi. I build a fork with a complete, simple new design. A small logo update is added, too.

Hallo Starcommander! Du kannst ja mal in meine "geschwedete" (aus dem Film "Abgedreht") Version deiner App reinschauen. In der Regel lege ich für f-droid einen Metadata ordner an, der dann von f-droid automatisch eingeladen wird. Auch ist mein .gitignore eine feine Sache. Was mir nicht gelungen ist, dass ist der add-Dialog. Der ist ganz schmal geworden. Ich hab die Icons angepasst auf eine feste breite und viele weggeworfen... ich glaube die kleinen größen sind bei API 19 nicht mehr nötig.

Ich mag deine App und bin froh, dass sie FOSS ist. Weiter so! :-)

Starcommander commented 5 years ago

Nice! I will have a closer look at your fork-project as soon I have the time. Maybe it is a good idea to update StreamRadio with some of your changes? Schöne Grüße aus Österreich ;)

no-go commented 5 years ago

Hi. There are some aspects I have to check (if I found time):

After checking/fixing it, I did a 2nd fork, modifying it again (in a minimalism way), and finally I try a merge-request with your code/repository. Actually I changed the app signature and package name to run both apps parallel. Feel free to adopt may changes. Alternatively you can wait for my merge request in the future. ;-)

Viele Grüße vom Niederrhein

no-go commented 5 years ago

Ok. fixed:

You may test the apk in my fork and give me a feedback. ;-)

Starcommander commented 5 years ago

Hello @no-go I tried your apk, and it looks nice. Android 7.1.2 (LineageOS) Thanks for your effort, good work!

Some ideas that we could implement next:

Single instance, so that WebRadio does not overlay the mainframe twice.

Better feedback about player is busy.

Maybe user should be able to select between day- and nightmode, use it timebased, or use the sensor? And of course, I will also update default channel list again.

no-go commented 5 years ago

Hi @Starcommander You are right. I think it is better to add a "black mode" checkbox to the options menu instead of the automatic (time based) night mode. I will try to copy this from another app of mine.

I will try to add and test the "singleTask" mode.

I although think, that a processbar is a good choice. I will try to add it. I have a additional question: I found different App names and labelings: WebRadio, StreamRadio and WebStreamRadio. Why? I think the labeling should be "WebRadio" all the time (?)

In another app of mine I add control buttons to a notification. I think it is not to hard to add a single, toggling "play/pause" button.

Hm. I think it is easyier for me not to make a new "clean" fork. So we have to see how we can get it back into your repository in the future :-P

Starcommander commented 5 years ago

@no-go Yes I agree, WebRadio should be used all times. You should now be able to check in directly into Repository of WebRadio. (Invitation sent) As long as you do not create a new release - feel free to check in some changes directly.

no-go commented 5 years ago

:o)

no-go commented 5 years ago

Hi. I think my "merge" was really successful. The only open point is: play/pause actions into the notifications. I am struggeling at that point, because it will be a too big untested code part.

Test and compile it and enjoy. Maybe do a new clone on your system, because I remvoe and "gitignore" some unimportant folders from intellij/anroid studio.

no-go commented 5 years ago

logo and design is "fixed" since https://github.com/Starcommander/StreamRadio/commit/7955484e4d7a2e81d21ec23841b4dc9182435614

additionaly the logo above is far away from the classic one, is'n it? :o)