Memory leak still continues

Starcounter-Jack / JSON-Patch

Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.

MIT License

1.82k stars 215 forks source link

Memory leak still continues #214

Open pnowak opened 5 years ago

pnowak commented 5 years ago

Hi.

When I added JSON-Patch to dependencies (so after yours fix https://github.com/Starcounter-Jack/JSON-Patch/pull/212/files) and I implemented the slowCheck removed by you to our dataObserver - https://github.com/handsontable/handsontable/pull/5575 - we noticed that the memory leak still continues. Unless I did something wrong.

alshakero commented 5 years ago

Hi!

and I implemented the slowCheck removed by you

Could you elaborate more on this? It's true that I maintain this lib but I don't remember removing this. Could you link the PR or the commit I (or someone) did this? You'd make it easier for me to help.

Thanks

pnowak commented 5 years ago

I thought about this PR - https://github.com/Starcounter-Jack/JSON-Patch/pull/104 We need this slowCheck, because we need observe changes, not only react to DOM events.