search

Starcounter-Jack / JSON-Patch

Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.
MIT License
1.79k stars 215 forks source link

Is it realy tested on IE8? #223

Closed mort3za closed 5 years ago

mort3za commented 5 years ago

In the source code I see new WeakMap() which is only available in IE11. Also I've tested it on IE9 and it has an error for using WeakMap.

alshakero commented 5 years ago

You're right. It would be appreciated if you could PR to fix the README.

mort3za commented 5 years ago

I recommend you to generate an es5 version of the library beside current build If you want to keep es6 version (and it's a good idea because it's faster and smaller).

alshakero commented 5 years ago

Sorry but we're not willing to maintain support for IE8. We only support IE10+ for the meantime.

mort3za commented 5 years ago

IE10+ means included IE10, right? IE10 don't understand WeakMap :)

Personally I have no problem with or without IE support, because I have included babel-polyfill, But I think supporting more browers leads to fewer hassles for developers.

warpech commented 5 years ago

We will fix the readme to say that only IE11 is supported directly. Older browsers can by supported using a polyfill, however WeakMap is not completely polyfillable.