search

Starcounter-Jack / JSON-Patch

Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.
MIT License
1.79k stars 215 forks source link

Specs/tests link in readme broken #234

Open vollmerr opened 5 years ago

vollmerr commented 5 years ago

The 'Run in browser' under Specs/tests in the readme pointing to http://starcounter-jack.github.io/JSON-Patch/test/ gives a blank screen with a bunch of 404's

tomalec commented 5 years ago

Thanks for reporting @vollmerr. The issue was probably introduced by me, when I switched test runner to use Jasmine & co. from node_modules instead of local hard-copy.

Locally you can run it by:

npm install && npm run serve

Then visit http://localhost:5000/test/index

@warpech Do you think we should:

  1. Use Jasmine from CDN for HTML spec runner https://github.com/Starcounter-Jack/JSON-Patch/blob/master/test/index.html (will stop working offline, locally)
  2. Push Jasmine back to the repo
  3. Remove this link from README
warpech commented 5 years ago
  1. Wait for https://github.com/Starcounter-Jack/JSON-Patch/pull/232, because the HTML spec runner works OK there for any browser that supports ES modules.
tomalec commented 5 years ago

How would that help? it still uses ../node_modules/jasmine-core... https://github.com/Starcounter-Jack/JSON-Patch/blob/use-ES6-modules/test/index.html#L10

warpech commented 5 years ago

How would that help? it still uses ../node_modules/jasmine-core... /test/index.html@use-ES6-modules#L10

Sorry, my bad. I tested locally with npm run serve and it worked well because I have node_modules locally.

Then I vote for 3. Maybe we can replace the link to spec runner with a link to working example on JSFiddle?

grempe commented 1 year ago

FYI, I see this error in the console proper to all the 404's

Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'interest-cohort'.

Perhaps related:

https://developer.chrome.com/docs/privacy-sandbox/permissions-policy/

https://www.studytonight.com/post/solved-error-with-permissionspolicy-header-parse-of-permission-policy-failed