search

Starcounter-Jack / JSON-Patch

Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.
MIT License
1.79k stars 215 forks source link

Revert typescript to 2.2.0, #235

Closed tomalec closed 5 years ago

tomalec commented 5 years ago

the version that was not adding Object.defineProperty(exports, "__esModule", { value: true }); Therefore, resulting in module transpilable to one with unintended default export.

Fixes backward compatibility and https://github.com/Starcounter-Jack/JSON-Patch/issues/233

warpech commented 5 years ago

I just pushed one change, which adds tests for few external API use scenarios:

There is one known problem in TypeScript: The test in line https://github.com/Starcounter-Jack/JSON-Patch/blob/2ccf6212a30468de1eeb3291b51edf50c7a98f0d/test/spec/typings/typingsSpec.ts#L17 is commented out, because it fails since there is no default export in lib/duplex.js.

@tomalec would you care fixing that by adding an actual default export?

tomalec commented 5 years ago

Closing in favour of https://github.com/Starcounter-Jack/JSON-Patch/pull/236 it seems we have to export default anyway, to make TS happy, so we could keep using latest TS version.