Starcounter-Jack / JSON-Patch

Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.
MIT License
1.81k stars 215 forks source link

TravisCI is not actually running all of your tests. This PR fixes the broken test script. #245

Closed jaylattice closed 4 years ago

jaylattice commented 4 years ago

image

I found a few edge cases that aren't tested in this library, so I updated the validation tests (can send a PR later if I ever get around to fixing the code). Unfortunately I ran npm run test more times than I care to admit before realizing that the test script isn't actually running all of the tests.

The script only looks at the first command-line argument, but the script test-core passes in 3 command-line arguments! So, this PR changes that to a single glob pattern, ensuring that all tests run via npm run test. Note that the browser tests don't suffer from this problem.