search

Starcounter / DevTools

A browser extension that helps you debug Starcounter apps with ease
3 stars 1 forks source link

Enhancements #72

Closed alshakero closed 6 years ago

alshakero commented 6 years ago

Because I'm used to working alone on this most of the time. I didn't pull before working so some of @warpech changes weren't released in 3.2.0. But I'll release just for them after this review.

I released 3.2.0 before this PR because I forgot about the new restrictions of pushing to master.

What's new?

  1. It now runs inside ShadowDOM to avoid CSS and element ID's collisions.
  2. It now has beta health checks tab.
  3. CSS is enhanced a little.

Fixes https://github.com/Starcounter/DevTools/issues/5 & https://github.com/Starcounter/DevTools/issues/71

warpech commented 6 years ago

You have committed 2 zip files in https://github.com/Starcounter/DevTools/pull/72/commits/1bd698ce8316e575d496e6539303e1305e1ca94f. I guess that's unintended?

alshakero commented 6 years ago

How is it possible without a revert commit bettwen them?

Haha you know git. What happened is that your changes don't conflict with mine only in src folder so my changes could be committed after yours. THEN I built and now your changes are in dist. So they tricked you into believing they happened twice.

warpech commented 6 years ago

That I would understand, but I can see that even for the changes in README.md file. This file is not in build.