Starcounter / DevTools

A browser extension that helps you debug Starcounter apps with ease
3 stars 1 forks source link

⏰ Overlay doesn't work as should #82

Closed Mihaiii closed 6 years ago

Mihaiii commented 6 years ago

Please see the gif for steps (I try to expand "WebsiteProvider_0", but it doesn't work and I try to select "Text" option, but it doesn't work). The version is 3.3.1 (current latest on Chrome Web Store).

bug_sda

Haven't tried with another app because I would have to install another version of SC first. @alshakero , if you have a "normal" SC 2.4 version already installed, please try it first with another app.

Mihaiii commented 6 years ago

I tried it now on http://inside.starcounter.com/people - same problem so it's not app related.

alshakero commented 6 years ago

Thank you for reporting! I managed to repro it. Will look into it.

Mihaiii commented 6 years ago

same problem so it's not app related.

I had an actual look on it and it kinda is app related in a sense that the Search app sends a patch whenever a click is made.

But a closely related issue here is that the whole tree is reevaluated whenever a patch is sent from the client, which would reset the path (that the user choose using "View-Model" tab with "tree" option).

Since the refresh of the whole tree whenever a patch is sent from the client is not really going to change very soon and also because probably the code of DevTools shouldn't be changed for this "external issue" (I don't know), the current issue might not be as urgent as the initial post suggests.

Here is an example using the popup mode (and not the overlay mode). Please notice how the path text isn't updated, even though nothing is expanded anymore:

devtools

Search app branch master-2.4 will be upgraded with this commit or this commit in order to avoid the problem shown in the initial post.

warpech commented 6 years ago

Solved in the release https://github.com/Starcounter/DevTools/releases/tag/3.5.0 by removing of the overlay mode. Now there is only the popup mode.