Starcounter / Home

Starcounter is an in-memory database application engine.
https://starcounter.io
27 stars 1 forks source link

Request.PortNumber returns 0 #249

Closed un-tone closed 7 years ago

un-tone commented 7 years ago

I tested on WebsiteProvider app.

Steps to reproduce

  1. Run WebsiteEditor and WebsiteProvider apps from develop branch in debug mode.
  2. Set breakpoint on ContentHandlers.cs:74
  3. Check value of the request.PortNumber

Technical information

Starcounter version 2.3.1.7280
warpech commented 7 years ago

@alemoi can you pls take a look?

@un-tone is this a regression? How does it affect Website app or other apps?

warpech commented 7 years ago

Reply to self - it causes tests in Website app to fail: https://github.com/StarcounterApps/Website/pull/197#issuecomment-331379038, so this must be a regression.

@miyconst I advise this goes in 2.3.1

un-tone commented 7 years ago

I use it when calling Handler.GetHandlerForUri(string method, string uri, ushort portNumber) method here.

ghost commented 7 years ago

Thanks for reporting @un-tone Fixed, now returns user handlers port, e.g. 8080.