search

Starcounter / Home

Starcounter is an in-memory database application engine.
https://starcounter.io
27 stars 1 forks source link

Upgrade failed - Redistributable 2017 error #430

Closed mmnosek closed 6 years ago

mmnosek commented 6 years ago

I try to upgrade from 2.4.990.120 to 2.4.990.122. Communicate shows: “Microsoft Visual Studio Redistributable 2017 is not detected (…) It will be installed now” When I hit “OK”, I have this immediately: Starcounter setup failed. Returned error code: 1638. Error: Installation of Microsoft Redistributable failed

miyconst commented 6 years ago

@iqbalskd could you please follow up?

iqbalskd commented 6 years ago

It seems like a bug with VC ++ Redistributable 14.14.x.x If you have VC++ Redistributable 2017 Installed and try to install Starcounter it failes with the exact same error.

Steps Copied from Microsoft Bug Report

here is actually a bug here, installing latest version VC++ 2017 on top of a previous installation results in the registry key typically used for detecting the installation being removed.

Registry key to observe:

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x64

Steps to reproduce:

1) Install VC++ 2015, see registry key exists and should show a version of roughly ~ 14.0.x.x

2) Install VC++ 2017, see registry key is removed

3) Repair VC++ 2017, see registry key is restored and should now have the correct version of 14.14.x.x

Version of VC++ 2017 used to reproduce the issue: 14.14.26405.0

Workaround for this issue is to Repair VC++ 2017 which brings the registry keys back.

miyconst commented 6 years ago

@mmnosek could you please validate the answer from @iqbalskd?

iqbalskd commented 6 years ago

Even easier steps to reporduce:

  1. Uninstall all versions of VC++Redistributable
  2. Install VC++ Redistributable 2017
  3. Try Installing any version of Starcounter. @mmnosek
mmnosek commented 6 years ago

I confirm. So it's not our bug. I know more people have encoutered this. Can we add some information somewhere? In the installer? In the docs? On the downloads page? @miyconst @Mackiovello wdyt?

Mackiovello commented 6 years ago

I think people will find this issue pretty fast if they hit it which explains it. Don't think it's a good idea to add to the installer or something like that

miyconst commented 6 years ago

I am with @Mackiovello on this. If we add anything extra for it, then we will have to keep track of the VS issue and remove that "extra" thing once the VS issue is resolved.

bigwad commented 6 years ago

I confirm. So it's not our bug.

How is that? Microsoft closed the mentioned issue with a resolution "Closed - Not a Bug". So, no reason to wait for MS to fix it. We have to accept it and fix on our side.

miyconst commented 6 years ago

@bigwad is not it what the MS representative says after closing the issue?

We are aware (and acknowlege) the issues that occur with the current behavior related to attempted downgrades and we are looking into changes to the VC++ redistributable bundle that could be made to allow us to avoid these issues in the future.

bigwad commented 6 years ago

we are looking into changes to the VC++ redistributable bundle that could be made to allow us to avoid these issues in the future.

We don't know what is he talking about and it might be that they will start releasing redistributables that won't fail being installed on top of a newer one. But it won't make a change for the redistributable that we carry. Nobody knows what and when they will do, most probably nothing. And the bug is closed. Should I also say, that installer is the face of a product?

bigwad commented 6 years ago

Plus serious companies don't do installations manually - only unattended. Will we suggest them writing a script for installing starcounter?

mmnosek commented 6 years ago

How is that?

I didn't check Microsoft, just acknowledged information from @iqbalskd and @miyconst. I am not knowledgeable enough to debug it myself.

Should I also say, that installer is the face of a product?

I agree 120%. I am all for the installer that does its job smoothly.

iqbalskd commented 6 years ago

Well Microsoft has released recently a new version of VC ++ Redistributable v14.15.x.x and this issue has now been resolved.

However the issue will appear if the user computer has the faulty version (14.14.x.x) and trying to install old starcounter releases.

I will upgrade VC ++ Redistributable to the lastest 14.15.x.x.

iqbalskd commented 6 years ago

Changed the VC++ resdist to 14.15.x.x on the FTP

\scbuildserver\FTP\SCDev\ThirdParty\VCRedistSetups\VS2017

Pending:

iqbalskd commented 6 years ago

Closing this as done