search

Starcounter / Starcounter.ErrorCodes

Errorcodes for all Starcounter versions.
0 stars 0 forks source link

Remove unneeded dependencies #20

Open linkdata opened 7 years ago

linkdata commented 7 years ago

Starcounter.ErrorCodes.csproj contains these:

  <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
    <!-- Neccessary until we see a fix for: https://github.com/dotnet/roslyn/issues/16040 -->
    <PackageTargetFallback>portable-net45+win8</PackageTargetFallback>
  </PropertyGroup>

  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.6' ">
    <PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
  </ItemGroup>

The issue referenced in the first comment is closed. There is no reference to System.Diagnostics.TraceSource in the code.

linkdata commented 7 years ago

There is no reference to System.Diagnostics.TraceSource in the code.

Oh, there is. Found them.

linkdata commented 7 years ago

However, the dependency can be removed by simply using System.Diagnostics.Debug.Trace instead, which is already depended on.

@chrhol would that be a problem?

The point of this is to reduce the dependencies pulled in when depending on the Starcounter.ErrorCodes package.

linkdata commented 7 years ago

Also, the .NET Core framework reference can be lowered a lot. Probably at least to netstandard1.2.

linkdata commented 7 years ago

Remember to change the framework dependency in level0\src\sccoreerr\GetStarcounterErrorCodes\GetStarcounterErrorCodes.csproj (branch issue/282) to netstandard1.0 once this is done.

chrhol commented 7 years ago

@chrhol would that be a problem?

Sounds good to me.

Also, the .NET Core framework reference can be lowered a lot. Probably at least to netstandard1.2.

If that would be the case then we would no longer need to build for multiple platforms, right? Since netstandard 1.2 is supported in .net 4.5.1.

linkdata commented 7 years ago

If that would be the case then we would no longer need to build for multiple platforms, right? Since netstandard 1.2 is supported in .net 4.5.1.

I don't know. We'll have to test. I've lowered the requirement to netstandard1.0, which is enough.