search

Starcounter / Starcounter.VisualStudio

Starcounter Visual Studio development support
0 stars 0 forks source link

Update dom-bind template for Pomyler 2 (For #25) #26

Closed PatrykSzwer closed 6 years ago

PatrykSzwer commented 6 years ago

I'm not sure if I should target this PR to develop branch or master. I've made it to the default develop right now. Let me know If I should change that.

warpech commented 6 years ago

In response to @alshakero's review, I'd rather have just one comment in this template:

<!--
    <dom-bind><template is="dom-bind"> is a Polymer 2 auto-binding template
    with a compatibility fallback for Polymer 1. See:
    https://www.polymer-project.org/2.0/docs/devguide/templates
-->
PatrykSzwer commented 6 years ago

I've made a change due to @warpech comment. Please take a look.

PatrykSzwer commented 6 years ago

Due to @warpech comment: https://github.com/Starcounter/Starcounter.VisualStudio/issues/25#issuecomment-356010111 @ubbeK I'm pinging You to release a new version of the extension. 😃

warpech commented 6 years ago

Release in Visual Studio marketplace is tracked in https://github.com/Starcounter/Starcounter.VisualStudio/issues/27