search

Starcounter / Starcounter.VisualStudio

Starcounter Visual Studio development support
0 stars 0 forks source link

Remove hardcoded targetframeworkversion #30

Closed Mihaiii closed 6 years ago

Mihaiii commented 6 years ago

master branch is for SC 2.3, I assume.

After this PR is merged, I will make the change for develop branch (I assume it's the official branch for SC 2.4).

A release needs to be made first before changing level1. For clarity, I don't intend to make the release, unless someone specifies it.

For https://github.com/Starcounter/Home/issues/354

Mihaiii commented 6 years ago

Out of curiosity, did you any documentation regarding targetframeworkversion variable? Did some googling but didn't find much regarding it when creating a new project.

No, I haven't. Where should it be mentioned considering that it's a bug fix, not a feature?

Mihaiii commented 6 years ago

@ubbeK , I'm going to make the merge because apparently github's interface doesn't allow to make two PRs from the same branch.

Please let me know here or on Slack if I need to update anything else.