search

Starcounter / Starcounter.VisualStudio

Starcounter Visual Studio development support
0 stars 0 forks source link

Update template for usage with Polymer 2 #37

Closed Mihaiii closed 6 years ago

alshakero commented 6 years ago

Bump

Mihaiii commented 6 years ago

I avoided merging this because it didn't got all the requested approvals. Regarding the referenced issue, please confirm that is 100% safe to remove <link rel="import" href="/sys/polymer/polymer.html"> so I can make that commit and then merge it directly.

alshakero commented 6 years ago

I don't recommend removing Polymer import at all, because:

  1. We might remove Polymer from the app-shell. Leaving every view to decide what imports it needs. I.e slightly more atomic views.
  2. It's deduped so it doesn't hurt.
  3. It gives meaning to dom-bind, when you remove Polymer, dom-bind will look way more outlandish.

@tomalec agree?

Mihaiii commented 6 years ago

Merging. If it will be decided that <link rel="import" href="/sys/polymer/polymer.html"> should be removed, please make another PR.