Add service-worker-source and update the app-shell accordingly

Starcounter / StarcounterClientFiles

An app that provides Starcounter with all the client-side libraries it needs to function.

1 stars 0 forks source link

Add service-worker-source and update the app-shell accordingly #138

Closed alshakero closed 5 years ago

alshakero commented 5 years ago

Released on Nuget under 3.26.0-rc0

Heads up to @warpech

warpech commented 5 years ago

The build with tests has failed, I am investigating why

warpech commented 5 years ago

Started a new build: https://teamcity.starcounter.org/viewLog.html?buildId=95718&buildTypeId=Apps_WebPlatform_StarcounterClientFiles_TestWithApps

warpech commented 5 years ago

Great fixes!

It is possible for you to add another file next to app-shell.html (let's call it app-shell-no-service-worker.js, which contains the solution to uninstall the service worker explained in https://github.com/Starcounter/UniformDocs/pull/357#issuecomment-485847339?

The instruction for solution owners will be to replace app-shell.html with app-shell-no-service-worker.js if there is a need to disable SW for the clients.

alshakero commented 5 years ago

Done.