search

Starcounter / starcounter-upload

Starcounter custom component to upload files over WebSocket
MIT License
0 stars 0 forks source link

Typo inside starcounter-upload #5

Closed Joltrix closed 7 years ago

Joltrix commented 7 years ago

inside starcounter-upload.html there is a function called isSumbitVisible,

I'm guessing that should be isSubmitVisible?

(Not sure if this is "important enough" to qualify as an issue but I just thought I'd at least let you know ~)

cc @warpech

warpech commented 7 years ago

Yeah, everything is important, especially such low hanging fruits are nice when you want to have a feel good sensation of fixing something :) Feel free to fix that, but the priority is not big at all

miyconst commented 7 years ago

@Joltrix I thought you were talking about the starcounter-include, since it is in starcounter-upload feel free to fix it and release a new version, then install wherever it is needed 😄.