Stardust-Labs-MC / Terralith

A popular Minecraft worldgen datapack for the Overworld
https://www.planetminecraft.com/data-pack/terralith-overworld-evolved-100-biomes-caves-and-more/
Other
120 stars 14 forks source link

[Bug] ModernFix + Terralith 1.19.2 Forge #98

Closed Krimatoria closed 4 months ago

Krimatoria commented 7 months ago

What Minecraft version(s) does this apply to?

1.19.x

Project version

Terralith_1.19.3_v2.3.12.jar

Mod or datapack version?

Mod (Forge)

Describe the bug

[23����.2024 03:40:57.078] [Worker-Main-4/DEBUG] [ModernFix/]: Structure terralith:underground/smallminingoutpost is being run through DFU (hash 9f4d2d29abe643289f5ce6dec593e783e713721c6f3eef71ff2219e5e1a426ab), this will cause launch time delays [23����.2024 03:40:57.735] [Worker-Main-4/DEBUG] [mixin/]: Mixing SubShapeAccess from ferritecore.blockstatecache.mixin.json into net.minecraft.world.phys.shapes.SubShape [23����.2024 03:40:57.843] [Worker-Main-4/DEBUG] [ModernFix/]: Structure terralith:underground/old_refinery is being run through DFU (hash 8ddf79e31cc483d60715287bdc3b015d4c1e336e2b1c048601e163548b8c0294), this will cause launch time delays [23����.2024 03:42:45.522] [Worker-Main-5/DEBUG] [ModernFix/]: Structure terralith:ruin/glacial/interior1 is being run through DFU (hash 177372923eb6a9e054ad90ce38060773071dda764cda7ec65d128eaf3642ed6f), this will cause launch time delays [23����.2024 03:49:19.563] [Worker-Main-1/DEBUG] [ModernFix/]: Structure terralith:ruin/glacial/interior2 is being run through DFU (hash 6dedf627f70e92d0c4de628846bbc67f90a7607bd719158f74232f99848480ba), this will cause launch time delays

Additional context

No response

catter1 commented 7 months ago

Thanks, I'll take a look at i when I get a chance. The delays ModernFix shows you aren't a huge deal, and will not cause your load time to be as long as they imply. But it is a tiny opitimzation I can make nonetheless.

catter1 commented 4 months ago

This will likely not happen. Due to some tests by some others, the startup time impact is measured in milliseconds. It's negligible.