Starefossen / docker-github-pages

:octocat: :whale: Alpine Docker Image for GitHub Pages and Jekyll powered sites
https://registry.hub.docker.com/u/starefossen/github-pages/
MIT License
192 stars 54 forks source link

Container does not stop when syntax error encountered #62

Open mrmanc opened 5 years ago

mrmanc commented 5 years ago

I’ve found when using this image to run GHP sites that the container doesn’t stop when I hit ctrl-c if warnings were encountered in the Jekyll site. This leaves a container running in the background that I have to terminate manually and I constantly fail to notice, only realising when trying to launch another site.

e.g. Liquid Warning: Liquid syntax error (line 24): Unexpected character " in "{{ "/images/2019-02-14/image.png" | relative_url" }}" in /usr/src/app/_posts/2019-02-14-post.md

(the syntax error here being the double quote after the relative_url filter)

I thought this might be something to do with the exit code of the command, but running jekyll outside the container shows an exit code of 0